On Thu, Feb 14, 2019 at 10:56 AM Enrico Weigelt, metux IT consult
wrote:
> On 08.02.19 15:25, Linus Walleij wrote:
>
> >> +config GPIO_AMD_FCH
> >> + tristate "GPIO support for AMD Fusion Controller Hub (G-series
> >> SOCs)"
> >> + select GPIO_GENERIC
> >
> > You are selecting
On 08.02.19 15:25, Linus Walleij wrote:
Hi,
>> +config GPIO_AMD_FCH
>> + tristate "GPIO support for AMD Fusion Controller Hub (G-series SOCs)"
>> + select GPIO_GENERIC
>
> You are selecting GPIO_GENERIC, is this necessary? I thought
> X86 was already selecting this.
Doesn't look so
On 13.02.19 10:02, Linus Walleij wrote:
Hi,
> What we normally do is expose all the lines from a gpio chip> as kernel
> abstraction.> > This is because at least in theory this chip
can be used by> several boards.
I'm afraid it's a bit more complicated. The register set doesn't
seem to be
On Mon, Feb 11, 2019 at 11:46 AM Enrico Weigelt, metux IT consult
wrote:
> On 08.02.19 15:25, Linus Walleij wrote:
> >> +/*>> + * struct amd_fch_gpio_reg - GPIO register definition>> + * @reg:
> register index>> + * @name: signal name>> + */>> +struct
> amd_fch_gpio_reg {>> +int
On 08.02.19 15:25, Linus Walleij wrote:
Hi,
>> +/*>> + * struct amd_fch_gpio_reg - GPIO register definition>> + * @reg:
register index>> + * @name: signal name>> + */>> +struct
amd_fch_gpio_reg {>> +int reg;>> +const char* name;>>
+};> > Can't you put this in the driver file?
On Fri, 2019-02-08 at 15:25 +0100, Linus Walleij wrote:
> > +/*
> > + * GPIO driver for the AMD G series FCH (eg. GX-412TC)
> > + *
> > + * Copyright (C) 2018 metux IT consult
> > + * Author: Enrico Weigelt
> > + *
> > + * SPDX-License-Identifier: GPL+
> > + */
>
> I think checkpatch will
On Fri, Feb 8, 2019 at 4:26 PM Linus Walleij wrote:
>
> Hi Enrico!
>
> Thanks for your patch! I would really like Andy to have a look at it
> too, he's more on top of things in the x86 world.
Seems that is the same version sent twice. I already gave a long review on it.
--
With Best Regards,
Hi Enrico!
Thanks for your patch! I would really like Andy to have a look at it
too, he's more on top of things in the x86 world.
On Fri, Feb 8, 2019 at 2:16 AM Enrico Weigelt, metux IT consult
wrote:
> From: "Enrico Weigelt, metux IT consult"
>
> GPIO platform driver for the AMD G-series PCH
On 07.02.19 19:06, Andy Shevchenko wrote:
Hi,
> Overall I have a feeling that this driver can be replaced with> existing
> generic one where one register per pin is allocated.>
Unfortunately, I didn't look deep into this and hope Linus will help> to
figure this out.
this also was my first
From: "Enrico Weigelt, metux IT consult"
GPIO platform driver for the AMD G-series PCH (eg. on GX-412TC)
This driver doesn't registers itself automatically, as it needs to
be provided with platform specific configuration, provided by some
board driver setup code.
Didn't implement oftree
On Thu, Feb 7, 2019 at 7:14 PM Enrico Weigelt, metux IT consult
wrote:
>
> GPIO platform driver for the AMD G-series PCH (eg. on GX-412TC)
>
> This driver doesn't registers itself automatically, as it needs to
> be provided with platform specific configuration, provided by some
> board driver
GPIO platform driver for the AMD G-series PCH (eg. on GX-412TC)
This driver doesn't registers itself automatically, as it needs to
be provided with platform specific configuration, provided by some
board driver setup code.
Didn't implement oftree probing yet, as it's rarely found on x86.
12 matches
Mail list logo
