Re: [PATCH 1/2] x86 smpboot: fix cpu_init_udelay=10000

2015-11-05 Thread shrybman
> > Is this really what you intended? The else is commented out so if > > init_udelay is quirked > > to be 0 it will always be reset to UDELAY_10MS_DEFAULT. Also init_udelay is > > unsigned, so > > would UINT_MAX be a better choice? > > Hi Shane, > Thanks for pointing out this flaw. > Seems it

Re: [PATCH 1/2] x86 smpboot: fix cpu_init_udelay=10000

2015-11-05 Thread shrybman
> > Is this really what you intended? The else is commented out so if > > init_udelay is quirked > > to be 0 it will always be reset to UDELAY_10MS_DEFAULT. Also init_udelay is > > unsigned, so > > would UINT_MAX be a better choice? > > Hi Shane, > Thanks for pointing out this flaw. > Seems it

Re: [PATCH 1/2] x86 smpboot: fix cpu_init_udelay=10000

2015-11-02 Thread Len Brown
> Is this really what you intended? The else is commented out so if init_udelay > is quirked > to be 0 it will always be reset to UDELAY_10MS_DEFAULT. Also init_udelay is > unsigned, so > would UINT_MAX be a better choice? Hi Shane, Thanks for pointing out this flaw. Seems it will make 4.3 10ms

Re: [PATCH 1/2] x86 smpboot: fix cpu_init_udelay=10000

2015-11-02 Thread Len Brown
> Is this really what you intended? The else is commented out so if init_udelay > is quirked > to be 0 it will always be reset to UDELAY_10MS_DEFAULT. Also init_udelay is > unsigned, so > would UINT_MAX be a better choice? Hi Shane, Thanks for pointing out this flaw. Seems it will make 4.3 10ms

Re: [PATCH 1/2] x86 smpboot: fix cpu_init_udelay=10000

2015-10-16 Thread shrybman
> From: Len Brown > > For legacy machines cpu_init_udelay defaults to 10,000. > For modern machines it is set to 0. > > The user should be able to set cpu_init_udelay to > any value on the cmdline, including 10,000. > Before this patch, that was seen as "unchanged from default" > and thus on a

Re: [PATCH 1/2] x86 smpboot: fix cpu_init_udelay=10000

2015-10-16 Thread shrybman
> From: Len Brown > > For legacy machines cpu_init_udelay defaults to 10,000. > For modern machines it is set to 0. > > The user should be able to set cpu_init_udelay to > any value on the cmdline, including 10,000. > Before this patch, that was seen as "unchanged from

[PATCH 1/2] x86 smpboot: fix cpu_init_udelay=10000

2015-10-15 Thread Len Brown
From: Len Brown For legacy machines cpu_init_udelay defaults to 10,000. For modern machines it is set to 0. The user should be able to set cpu_init_udelay to any value on the cmdline, including 10,000. Before this patch, that was seen as "unchanged from default" and thus on a modern machine,

[PATCH 1/2] x86 smpboot: fix cpu_init_udelay=10000

2015-10-15 Thread Len Brown
From: Len Brown For legacy machines cpu_init_udelay defaults to 10,000. For modern machines it is set to 0. The user should be able to set cpu_init_udelay to any value on the cmdline, including 10,000. Before this patch, that was seen as "unchanged from default" and thus on