Re: [PATCH 1/2] xen/xenbus: avoid large structs and arrays on the stack

2020-05-12 Thread Jürgen Groß
On 11.05.20 20:01, Boris Ostrovsky wrote: On 5/11/20 3:31 AM, Juergen Gross wrote: static int xenbus_map_ring_valloc_hvm(struct xenbus_device *dev, I wonder whether we can drop valloc/vfree from xenbus_ring_ops' names. I can do that. + struct

Re: [PATCH 1/2] xen/xenbus: avoid large structs and arrays on the stack

2020-05-11 Thread Boris Ostrovsky
On 5/11/20 3:31 AM, Juergen Gross wrote: > > static int xenbus_map_ring_valloc_hvm(struct xenbus_device *dev, I wonder whether we can drop valloc/vfree from xenbus_ring_ops' names. > + struct map_ring_valloc *info, >

[PATCH 1/2] xen/xenbus: avoid large structs and arrays on the stack

2020-05-11 Thread Juergen Gross
xenbus_map_ring_valloc() and its sub-functions are putting quite large structs and arrays on the stack. This is problematic at runtime, but might also result in build failures (e.g. with clang due to the option -Werror,-Wframe-larger-than=... used). Fix that by moving most of the data from the