Re: [PATCH 1/2] xfs: show the dax option in mount options.

2020-12-01 Thread Michal Suchánek
On Thu, Nov 12, 2020 at 08:08:49AM -0800, Ira Weiny wrote: > On Thu, Nov 12, 2020 at 04:10:46PM +0100, Jan Kara wrote: > > On Thu 12-11-20 12:12:17, Michal Suchánek wrote: > > > On Thu, Nov 12, 2020 at 12:49:52PM +1100, Dave Chinner wrote: > > > > On Wed, Nov 11, 2020 at 11:28:48AM +0100, Michal

Re: [PATCH 1/2] xfs: show the dax option in mount options.

2020-11-12 Thread Ira Weiny
On Thu, Nov 12, 2020 at 04:10:46PM +0100, Jan Kara wrote: > On Thu 12-11-20 12:12:17, Michal Suchánek wrote: > > On Thu, Nov 12, 2020 at 12:49:52PM +1100, Dave Chinner wrote: > > > On Wed, Nov 11, 2020 at 11:28:48AM +0100, Michal Suchánek wrote: > > > > On Tue, Nov 10, 2020 at 08:08:23AM +1100,

Re: [PATCH 1/2] xfs: show the dax option in mount options.

2020-11-12 Thread Jan Kara
On Thu 12-11-20 12:12:17, Michal Suchánek wrote: > On Thu, Nov 12, 2020 at 12:49:52PM +1100, Dave Chinner wrote: > > On Wed, Nov 11, 2020 at 11:28:48AM +0100, Michal Suchánek wrote: > > > On Tue, Nov 10, 2020 at 08:08:23AM +1100, Dave Chinner wrote: > > > > On Mon, Nov 09, 2020 at 09:27:05PM

Re: [PATCH 1/2] xfs: show the dax option in mount options.

2020-11-12 Thread Michal Suchánek
On Thu, Nov 12, 2020 at 12:49:52PM +1100, Dave Chinner wrote: > On Wed, Nov 11, 2020 at 11:28:48AM +0100, Michal Suchánek wrote: > > On Tue, Nov 10, 2020 at 08:08:23AM +1100, Dave Chinner wrote: > > > On Mon, Nov 09, 2020 at 09:27:05PM +0100, Michal Suchánek wrote: > > > > On Mon, Nov 09, 2020 at

Re: [PATCH 1/2] xfs: show the dax option in mount options.

2020-11-11 Thread Dave Chinner
On Wed, Nov 11, 2020 at 11:28:48AM +0100, Michal Suchánek wrote: > On Tue, Nov 10, 2020 at 08:08:23AM +1100, Dave Chinner wrote: > > On Mon, Nov 09, 2020 at 09:27:05PM +0100, Michal Suchánek wrote: > > > On Mon, Nov 09, 2020 at 11:24:19AM -0800, Darrick J. Wong wrote: > > > > On Mon, Nov 09, 2020

Re: [PATCH 1/2] xfs: show the dax option in mount options.

2020-11-11 Thread Michal Suchánek
On Tue, Nov 10, 2020 at 08:08:23AM +1100, Dave Chinner wrote: > On Mon, Nov 09, 2020 at 09:27:05PM +0100, Michal Suchánek wrote: > > On Mon, Nov 09, 2020 at 11:24:19AM -0800, Darrick J. Wong wrote: > > > On Mon, Nov 09, 2020 at 08:10:08PM +0100, Michal Suchanek wrote: > > > > xfs accepts both dax

Re: [PATCH 1/2] xfs: show the dax option in mount options.

2020-11-10 Thread Christoph Hellwig
On Mon, Nov 09, 2020 at 08:10:08PM +0100, Michal Suchanek wrote: > xfs accepts both dax and dax_enum but shows only dax_enum. Show both > options. Which is very much intentional. The -o dax was an experimental hack that fortunately is gone now.

Re: [PATCH 1/2] xfs: show the dax option in mount options.

2020-11-09 Thread Dave Chinner
On Mon, Nov 09, 2020 at 09:27:05PM +0100, Michal Suchánek wrote: > On Mon, Nov 09, 2020 at 11:24:19AM -0800, Darrick J. Wong wrote: > > On Mon, Nov 09, 2020 at 08:10:08PM +0100, Michal Suchanek wrote: > > > xfs accepts both dax and dax_enum but shows only dax_enum. Show both > > > options. > > >

Re: [PATCH 1/2] xfs: show the dax option in mount options.

2020-11-09 Thread Michal Suchánek
On Mon, Nov 09, 2020 at 11:24:19AM -0800, Darrick J. Wong wrote: > On Mon, Nov 09, 2020 at 08:10:08PM +0100, Michal Suchanek wrote: > > xfs accepts both dax and dax_enum but shows only dax_enum. Show both > > options. > > > > Fixes: 8d6c3446ec23 ("fs/xfs: Make DAX mount option a tri-state") > >

Re: [PATCH 1/2] xfs: show the dax option in mount options.

2020-11-09 Thread Darrick J. Wong
On Mon, Nov 09, 2020 at 08:10:08PM +0100, Michal Suchanek wrote: > xfs accepts both dax and dax_enum but shows only dax_enum. Show both > options. > > Fixes: 8d6c3446ec23 ("fs/xfs: Make DAX mount option a tri-state") > Signed-off-by: Michal Suchanek > --- > fs/xfs/xfs_super.c | 2 +- > 1 file

Re: [PATCH 1/2] xfs: show the dax option in mount options.

2020-11-09 Thread Eric Sandeen
On 11/9/20 1:10 PM, Michal Suchanek wrote: > xfs accepts both dax and dax_enum but shows only dax_enum. Show both > options. Should probably indicate why this is needed in the changelog. > Fixes: 8d6c3446ec23 ("fs/xfs: Make DAX mount option a tri-state") > Signed-off-by: Michal Suchanek This

[PATCH 1/2] xfs: show the dax option in mount options.

2020-11-09 Thread Michal Suchanek
xfs accepts both dax and dax_enum but shows only dax_enum. Show both options. Fixes: 8d6c3446ec23 ("fs/xfs: Make DAX mount option a tri-state") Signed-off-by: Michal Suchanek --- fs/xfs/xfs_super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_super.c