Re: [PATCH 1/2 v3] misc: aspeed-lpc-snoop: Fix platform_get_irq's error checking

2017-11-19 Thread Alexandre Belloni
On 19/11/2017 at 10:04:00 +0530, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav > --- >

Re: [PATCH 1/2 v3] misc: aspeed-lpc-snoop: Fix platform_get_irq's error checking

2017-11-19 Thread Alexandre Belloni
On 19/11/2017 at 10:04:00 +0530, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav > --- > changes in v2 : >

[PATCH 1/2 v3] misc: aspeed-lpc-snoop: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2 : Add failure case '<= 0' instead of '< 0'.

[PATCH 1/2 v3] misc: aspeed-lpc-snoop: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2 : Add failure case '<= 0' instead of '< 0'. IRQ 0 is not valid. changes