Re: [PATCH 1/3] ASoC: AMD: Make ACP->SYSMEM DMA non circular

2018-08-06 Thread Agrawal, Akshu
On 8/2/2018 3:26 PM, Mark Brown wrote: > On Thu, Aug 02, 2018 at 12:11:54PM +0530, Akshu Agrawal wrote: >> In capture case we don't want ACP to SYSMEM dma >> to be circular. This is because if an in place DSP >> filter is applied to captured output then circular DMA >> can overwrite the filter

Re: [PATCH 1/3] ASoC: AMD: Make ACP->SYSMEM DMA non circular

2018-08-06 Thread Agrawal, Akshu
On 8/2/2018 3:26 PM, Mark Brown wrote: > On Thu, Aug 02, 2018 at 12:11:54PM +0530, Akshu Agrawal wrote: >> In capture case we don't want ACP to SYSMEM dma >> to be circular. This is because if an in place DSP >> filter is applied to captured output then circular DMA >> can overwrite the filter

[PATCH 1/3] ASoC: AMD: Make ACP->SYSMEM DMA non circular

2018-08-06 Thread Akshu Agrawal
In capture case we don't want ACP to SYSMEM dma to be circular. This is because if an in place DSP filter is applied to captured output then circular DMA can overwrite the filter value with stale data. Signed-off-by: Akshu Agrawal --- sound/soc/amd/acp-pcm-dma.c | 36

[PATCH 1/3] ASoC: AMD: Make ACP->SYSMEM DMA non circular

2018-08-06 Thread Akshu Agrawal
In capture case we don't want ACP to SYSMEM dma to be circular. This is because if an in place DSP filter is applied to captured output then circular DMA can overwrite the filter value with stale data. Signed-off-by: Akshu Agrawal --- sound/soc/amd/acp-pcm-dma.c | 36

Re: [PATCH 1/3] ASoC: AMD: Make ACP->SYSMEM DMA non circular

2018-08-02 Thread Mark Brown
On Thu, Aug 02, 2018 at 12:11:54PM +0530, Akshu Agrawal wrote: > In capture case we don't want ACP to SYSMEM dma > to be circular. This is because if an in place DSP > filter is applied to captured output then circular DMA > can overwrite the filter value with stale data. Isn't that just a

Re: [PATCH 1/3] ASoC: AMD: Make ACP->SYSMEM DMA non circular

2018-08-02 Thread Mark Brown
On Thu, Aug 02, 2018 at 12:11:54PM +0530, Akshu Agrawal wrote: > In capture case we don't want ACP to SYSMEM dma > to be circular. This is because if an in place DSP > filter is applied to captured output then circular DMA > can overwrite the filter value with stale data. Isn't that just a

[PATCH 1/3] ASoC: AMD: Make ACP->SYSMEM DMA non circular

2018-08-02 Thread Akshu Agrawal
In capture case we don't want ACP to SYSMEM dma to be circular. This is because if an in place DSP filter is applied to captured output then circular DMA can overwrite the filter value with stale data. Signed-off-by: Akshu Agrawal --- sound/soc/amd/acp-pcm-dma.c | 36

[PATCH 1/3] ASoC: AMD: Make ACP->SYSMEM DMA non circular

2018-08-02 Thread Akshu Agrawal
In capture case we don't want ACP to SYSMEM dma to be circular. This is because if an in place DSP filter is applied to captured output then circular DMA can overwrite the filter value with stale data. Signed-off-by: Akshu Agrawal --- sound/soc/amd/acp-pcm-dma.c | 36