Re: [PATCH 1/3] ASoC: sst-haswell-pcm: don't use snd_soc_pcm_set_drvdata()

2016-08-08 Thread Kuninori Morimoto
Hi Mark > > snd_soc_pcm_set_drvdata() will set driver data to rtd->dev, > > but driver data of rtd->dev is already used as "rtd" on > > soc_post_component_init(). > > This doesn't apply against current code, please check and resend. Thanks. It seems current your branch already has same patch.

Re: [PATCH 1/3] ASoC: sst-haswell-pcm: don't use snd_soc_pcm_set_drvdata()

2016-08-08 Thread Kuninori Morimoto
Hi Mark > > snd_soc_pcm_set_drvdata() will set driver data to rtd->dev, > > but driver data of rtd->dev is already used as "rtd" on > > soc_post_component_init(). > > This doesn't apply against current code, please check and resend. Thanks. It seems current your branch already has same patch.

Re: [PATCH 1/3] ASoC: sst-haswell-pcm: don't use snd_soc_pcm_set_drvdata()

2016-08-08 Thread Mark Brown
On Mon, Aug 01, 2016 at 06:09:54AM +, Kuninori Morimoto wrote: > > snd_soc_pcm_set_drvdata() will set driver data to rtd->dev, > but driver data of rtd->dev is already used as "rtd" on > soc_post_component_init(). This doesn't apply against current code, please check and resend.

Re: [PATCH 1/3] ASoC: sst-haswell-pcm: don't use snd_soc_pcm_set_drvdata()

2016-08-08 Thread Mark Brown
On Mon, Aug 01, 2016 at 06:09:54AM +, Kuninori Morimoto wrote: > > snd_soc_pcm_set_drvdata() will set driver data to rtd->dev, > but driver data of rtd->dev is already used as "rtd" on > soc_post_component_init(). This doesn't apply against current code, please check and resend.

[PATCH 1/3] ASoC: sst-haswell-pcm: don't use snd_soc_pcm_set_drvdata()

2016-08-01 Thread Kuninori Morimoto
snd_soc_pcm_set_drvdata() will set driver data to rtd->dev, but driver data of rtd->dev is already used as "rtd" on soc_post_component_init(). static int soc_post_component_init(xxx) { ... dev_set_drvdata(rtd->dev, rtd); ...

[PATCH 1/3] ASoC: sst-haswell-pcm: don't use snd_soc_pcm_set_drvdata()

2016-08-01 Thread Kuninori Morimoto
snd_soc_pcm_set_drvdata() will set driver data to rtd->dev, but driver data of rtd->dev is already used as "rtd" on soc_post_component_init(). static int soc_post_component_init(xxx) { ... dev_set_drvdata(rtd->dev, rtd); ...