Re: [PATCH 1/3] BTRFS: support NFSv2 export

2015-10-05 Thread Chris Mason
On Thu, Sep 24, 2015 at 11:59:02AM +1000, Neil Brown wrote: > David Sterba writes: > > > On Fri, May 08, 2015 at 10:16:23AM +1000, NeilBrown wrote: > >> The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as > >> that returned by encode_fh - it may be larger. > >> > >> With

Re: [PATCH 1/3] BTRFS: support NFSv2 export

2015-10-05 Thread Chris Mason
On Thu, Sep 24, 2015 at 11:59:02AM +1000, Neil Brown wrote: > David Sterba writes: > > > On Fri, May 08, 2015 at 10:16:23AM +1000, NeilBrown wrote: > >> The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as > >> that returned by encode_fh - it may be larger. > >>

Re: [PATCH 1/3] BTRFS: support NFSv2 export

2015-09-23 Thread Neil Brown
David Sterba writes: > On Fri, May 08, 2015 at 10:16:23AM +1000, NeilBrown wrote: >> The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as >> that returned by encode_fh - it may be larger. >> >> With NFSv2, the filehandle is fixed length, so it may appear longer >> than expected

Re: [PATCH 1/3] BTRFS: support NFSv2 export

2015-09-23 Thread Neil Brown
David Sterba writes: > On Fri, May 08, 2015 at 10:16:23AM +1000, NeilBrown wrote: >> The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as >> that returned by encode_fh - it may be larger. >> >> With NFSv2, the filehandle is fixed length, so it may appear longer

Re: [PATCH 1/3] BTRFS: support NFSv2 export

2015-05-11 Thread David Sterba
On Fri, May 08, 2015 at 10:16:23AM +1000, NeilBrown wrote: > The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as > that returned by encode_fh - it may be larger. > > With NFSv2, the filehandle is fixed length, so it may appear longer > than expected and be zero-padded. > > So

Re: [PATCH 1/3] BTRFS: support NFSv2 export

2015-05-11 Thread David Sterba
On Fri, May 08, 2015 at 10:16:23AM +1000, NeilBrown wrote: The fh_len passed to -fh_to_* is not guaranteed to be that same as that returned by encode_fh - it may be larger. With NFSv2, the filehandle is fixed length, so it may appear longer than expected and be zero-padded. So we must

[PATCH 1/3] BTRFS: support NFSv2 export

2015-05-07 Thread NeilBrown
The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as that returned by encode_fh - it may be larger. With NFSv2, the filehandle is fixed length, so it may appear longer than expected and be zero-padded. So we must test that fh_len is at least some value, not exactly equal to it.

[PATCH 1/3] BTRFS: support NFSv2 export

2015-05-07 Thread NeilBrown
The fh_len passed to -fh_to_* is not guaranteed to be that same as that returned by encode_fh - it may be larger. With NFSv2, the filehandle is fixed length, so it may appear longer than expected and be zero-padded. So we must test that fh_len is at least some value, not exactly equal to it.