Re: [PATCH 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation"

2018-09-11 Thread Yu Zhao
On Tue, Sep 11, 2018 at 05:36:36PM +0100, Mark Brown wrote: > On Tue, Sep 11, 2018 at 08:03:21AM +0200, Takashi Iwai wrote: > > Yu Zhao wrote: > > > > Will fix the problems in the following patches. Also attaching the > > > crash for future reference. > > > > [ 16.950887] RIP:

Re: [PATCH 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation"

2018-09-11 Thread Yu Zhao
On Tue, Sep 11, 2018 at 05:36:36PM +0100, Mark Brown wrote: > On Tue, Sep 11, 2018 at 08:03:21AM +0200, Takashi Iwai wrote: > > Yu Zhao wrote: > > > > Will fix the problems in the following patches. Also attaching the > > > crash for future reference. > > > > [ 16.950887] RIP:

Re: [PATCH 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation"

2018-09-11 Thread Mark Brown
On Tue, Sep 11, 2018 at 08:03:21AM +0200, Takashi Iwai wrote: > Yu Zhao wrote: > > Will fix the problems in the following patches. Also attaching the > > crash for future reference. > > [ 16.950887] RIP: 0010:snd_hdac_bus_update_rirb+0x19b/0x4cf [snd_hda_core] > > [ 16.950889] RSP:

Re: [PATCH 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation"

2018-09-11 Thread Mark Brown
On Tue, Sep 11, 2018 at 08:03:21AM +0200, Takashi Iwai wrote: > Yu Zhao wrote: > > Will fix the problems in the following patches. Also attaching the > > crash for future reference. > > [ 16.950887] RIP: 0010:snd_hdac_bus_update_rirb+0x19b/0x4cf [snd_hda_core] > > [ 16.950889] RSP:

Re: [PATCH 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation"

2018-09-11 Thread Takashi Iwai
On Mon, 10 Sep 2018 23:17:18 +0200, Yu Zhao wrote: > > This reverts commit 12eeeb4f4733bbc4481d01df35933fc15beb8b19. > > The patch doesn't fix accessing memory with null pointer in > skl_interrupt(). > > There are two problems: 1) skl_init_chip() is called twice, before > and after dma buffer

Re: [PATCH 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation"

2018-09-11 Thread Takashi Iwai
On Mon, 10 Sep 2018 23:17:18 +0200, Yu Zhao wrote: > > This reverts commit 12eeeb4f4733bbc4481d01df35933fc15beb8b19. > > The patch doesn't fix accessing memory with null pointer in > skl_interrupt(). > > There are two problems: 1) skl_init_chip() is called twice, before > and after dma buffer

[PATCH 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation"

2018-09-10 Thread Yu Zhao
This reverts commit 12eeeb4f4733bbc4481d01df35933fc15beb8b19. The patch doesn't fix accessing memory with null pointer in skl_interrupt(). There are two problems: 1) skl_init_chip() is called twice, before and after dma buffer is allocate. The first call sets bus->chip_init which prevents the

[PATCH 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation"

2018-09-10 Thread Yu Zhao
This reverts commit 12eeeb4f4733bbc4481d01df35933fc15beb8b19. The patch doesn't fix accessing memory with null pointer in skl_interrupt(). There are two problems: 1) skl_init_chip() is called twice, before and after dma buffer is allocate. The first call sets bus->chip_init which prevents the