Re: [PATCH 1/3] Revert "clk: rockchip: mark noc and some special clk as critical on rk3288"

Hi, On Thu, Apr 11, 2019 at 6:43 PM elaine.zhang wrote: > >>> - "pmu_hclk_otg0", > >>> > >>> It's a soc bug, pmu_hclk_otg0 must always on. > >>> > >>> So you said in your previous commit message. However we've shipped > >>> lots and lots of Chromebooks with this clock off. Can you explain

Re: [PATCH 1/3] Revert "clk: rockchip: mark noc and some special clk as critical on rk3288"

hi, 在 2019/4/12 上午6:05, Heiko Stübner 写道: Hi, Am Donnerstag, 11. April 2019, 17:26:41 CEST schrieb Doug Anderson: On Wed, Apr 10, 2019 at 8:27 PM elaine.zhang wrote: 在 2019/4/10 下午11:34, Doug Anderson 写道: On Tue, Apr 9, 2019 at 11:23 PM elaine.zhang wrote: 在 2019/4/10 上午4:47, Douglas

Re: [PATCH 1/3] Revert "clk: rockchip: mark noc and some special clk as critical on rk3288"

Hi, Am Donnerstag, 11. April 2019, 17:26:41 CEST schrieb Doug Anderson: > On Wed, Apr 10, 2019 at 8:27 PM elaine.zhang wrote: > > 在 2019/4/10 下午11:34, Doug Anderson 写道: > > On Tue, Apr 9, 2019 at 11:23 PM elaine.zhang > > wrote: > > 在 2019/4/10 上午4:47, Douglas Anderson 写道: > > > > This reverts

Re: [PATCH 1/3] Revert "clk: rockchip: mark noc and some special clk as critical on rk3288"

Hi, On Wed, Apr 10, 2019 at 8:27 PM elaine.zhang wrote: > > hi, > > 在 2019/4/10 下午11:34, Doug Anderson 写道: > > Hi, > > On Tue, Apr 9, 2019 at 11:23 PM elaine.zhang wrote: > > hi, > > 在 2019/4/10 上午4:47, Douglas Anderson 写道: > > This reverts commit 55bb6a633c33caf68ab470907ecf945289cb733d. > >

Re: [PATCH 1/3] Revert "clk: rockchip: mark noc and some special clk as critical on rk3288"

Hi, On Tue, Apr 9, 2019 at 11:23 PM elaine.zhang wrote: > > hi, > > 在 2019/4/10 上午4:47, Douglas Anderson 写道: > > This reverts commit 55bb6a633c33caf68ab470907ecf945289cb733d. > > > > The clocks that were enabled by that patch are pretty questionable. > > Specifically looking at what has been

Re: [PATCH 1/3] Revert "clk: rockchip: mark noc and some special clk as critical on rk3288"

hi, 在 2019/4/10 上午4:47, Douglas Anderson 写道: This reverts commit 55bb6a633c33caf68ab470907ecf945289cb733d. The clocks that were enabled by that patch are pretty questionable. Specifically looking at what has been shipping on rk3288-veyron Chromebooks almost all of these clocks are safely

[PATCH 1/3] Revert "clk: rockchip: mark noc and some special clk as critical on rk3288"

This reverts commit 55bb6a633c33caf68ab470907ecf945289cb733d. The clocks that were enabled by that patch are pretty questionable. Specifically looking at what has been shipping on rk3288-veyron Chromebooks almost all of these clocks are safely turned off and cause no apparent problems. If some