Re: [PATCH 1/3] Staging: comedi: Fix some raw printks with dev_warn()

2014-03-11 Thread Ian Abbott
On 2014-03-09 02:42, Conrad Meyer wrote: Brought to you with the help of sed and manual clean-up after. $ sed -i -e 's|printk("\\n|dev_warn(dev->hw_dev,\n\t"|' \ addi-data/hwdrv_apci1500.c Since all of these printk()s were for invalid API inputs and most of them returned -EINVAL, I

Re: [PATCH 1/3] Staging: comedi: Fix some raw printks with dev_warn()

2014-03-11 Thread Ian Abbott
On 2014-03-09 02:42, Conrad Meyer wrote: Brought to you with the help of sed and manual clean-up after. $ sed -i -e 's|printk(\\n|dev_warn(dev-hw_dev,\n\t|' \ addi-data/hwdrv_apci1500.c Since all of these printk()s were for invalid API inputs and most of them returned -EINVAL, I fixed

[PATCH 1/3] Staging: comedi: Fix some raw printks with dev_warn()

2014-03-08 Thread Conrad Meyer
Brought to you with the help of sed and manual clean-up after. $ sed -i -e 's|printk("\\n|dev_warn(dev->hw_dev,\n\t"|' \ addi-data/hwdrv_apci1500.c Since all of these printk()s were for invalid API inputs and most of them returned -EINVAL, I fixed the rest of them to return -EINVAL as

[PATCH 1/3] Staging: comedi: Fix some raw printks with dev_warn()

2014-03-08 Thread Conrad Meyer
Brought to you with the help of sed and manual clean-up after. $ sed -i -e 's|printk(\\n|dev_warn(dev-hw_dev,\n\t|' \ addi-data/hwdrv_apci1500.c Since all of these printk()s were for invalid API inputs and most of them returned -EINVAL, I fixed the rest of them to return -EINVAL as well.