Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Randy Dunlap
Satyam Sharma wrote: On 5/8/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: On Mon, 07 May 2007 16:31:48 -0400 Jeff Garzik wrote: > Satyam Sharma wrote: > > Yes, mixing select and depends is a recipe for build disasters. Call > > me a rabid fanatic, but I would in fact go as far as to say that

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Satyam Sharma
On 5/8/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: On Mon, 07 May 2007 16:31:48 -0400 Jeff Garzik wrote: > Satyam Sharma wrote: > > Yes, mixing select and depends is a recipe for build disasters. Call > > me a rabid fanatic, but I would in fact go as far as to say that this > > whole "select"

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Jeff Garzik wrote: > Tough, the kernel community has voted against you. > > It makes far more sense to include a driver during kernel configuration, and > have that driver pull in its libraries via 'select'. The lame alternative > requires developers to know which

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Krzysztof Halasa
Roman Zippel <[EMAIL PROTECTED]> writes: > Normal dependencies, you basically have to manually make sure they are > correct (and it seems with your patch they aren't). Again, _please_ (with > sugar on top) don't use select unless you have a good reason for it. You perhaps mean WAN dependency,

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Satyam Sharma
On 5/8/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > Yes, mixing select and depends is a recipe for build disasters. Call > me a rabid fanatic, but I would in fact go as far as to say that this > whole "select" thing in the Kconfig process is one big BUG, and not a > feature.

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Randy Dunlap
On Mon, 07 May 2007 16:31:48 -0400 Jeff Garzik wrote: > Satyam Sharma wrote: > > Yes, mixing select and depends is a recipe for build disasters. Call > > me a rabid fanatic, but I would in fact go as far as to say that this > > whole "select" thing in the Kconfig process is one big BUG, and not a

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Jeff Garzik
Satyam Sharma wrote: Yes, mixing select and depends is a recipe for build disasters. Call me a rabid fanatic, but I would in fact go as far as to say that this whole "select" thing in the Kconfig process is one big BUG, and not a feature. People are lazy by nature and would rather just "select"

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Satyam Sharma
On 5/7/07, Roman Zippel <[EMAIL PROTECTED]> wrote: Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Roman Zippel <[EMAIL PROTECTED]> writes: > > > HDLC doesn't really look like simple library code, what's up with all the > > HDLC_* options? > > Sub-modules. So it's not simple library code,

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Roman Zippel <[EMAIL PROTECTED]> writes: > > > HDLC doesn't really look like simple library code, what's up with all the > > HDLC_* options? > > Sub-modules. So it's not simple library code, or is it? > Anyway, what does the patch "screw"

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Krzysztof Halasa
Roman Zippel <[EMAIL PROTECTED]> writes: > HDLC doesn't really look like simple library code, what's up with all the > HDLC_* options? Sub-modules. Anyway, what does the patch "screw" exactly? -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Jeff Garzik wrote: > > select seriously screws with the dependencies, it's especially problematic > > if the selected symbol has other dependencies as HDLC in this case, it makes > > it only more complicated to get the dependencies correct again. > > Please use it only if

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Jeff Garzik
Roman Zippel wrote: Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: Actually I can't see any bad idea here. The original dependency was certainly, uhm, not the best one. select seriously screws with the dependencies, it's especially problematic if the selected symbol has other dependencies

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Actually I can't see any bad idea here. > The original dependency was certainly, uhm, not the best one. select seriously screws with the dependencies, it's especially problematic if the selected symbol has other dependencies as HDLC in this

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Krzysztof Halasa
Roman Zippel <[EMAIL PROTECTED]> writes: >> You don't have to know it's required, you can just select a driver >> for your hardware, without enabling HDLC first. > > Is this a real problem? I think the "select" is better. > Using select you should also consider removing HDLC as visible option

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Roman Zippel <[EMAIL PROTECTED]> writes: > > > What's the advantage? The HDLC option is directly before this? > > You don't have to know it's required, you can just select a driver > for your hardware, without enabling HDLC first. Is this a

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Krzysztof Halasa
Roman Zippel <[EMAIL PROTECTED]> writes: > What's the advantage? The HDLC option is directly before this? You don't have to know it's required, you can just select a driver for your hardware, without enabling HDLC first. -- Krzysztof Halasa - To unsubscribe from this list: send the line

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Krzysztof Halasa
Roman Zippel [EMAIL PROTECTED] writes: HDLC doesn't really look like simple library code, what's up with all the HDLC_* options? Sub-modules. Anyway, what does the patch screw exactly? -- Krzysztof Halasa - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: Roman Zippel [EMAIL PROTECTED] writes: HDLC doesn't really look like simple library code, what's up with all the HDLC_* options? Sub-modules. So it's not simple library code, or is it? Anyway, what does the patch screw exactly?

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Satyam Sharma
On 5/7/07, Roman Zippel [EMAIL PROTECTED] wrote: Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: Roman Zippel [EMAIL PROTECTED] writes: HDLC doesn't really look like simple library code, what's up with all the HDLC_* options? Sub-modules. So it's not simple library code, or is it?

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Jeff Garzik
Satyam Sharma wrote: Yes, mixing select and depends is a recipe for build disasters. Call me a rabid fanatic, but I would in fact go as far as to say that this whole select thing in the Kconfig process is one big BUG, and not a feature. People are lazy by nature and would rather just select a

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Randy Dunlap
On Mon, 07 May 2007 16:31:48 -0400 Jeff Garzik wrote: Satyam Sharma wrote: Yes, mixing select and depends is a recipe for build disasters. Call me a rabid fanatic, but I would in fact go as far as to say that this whole select thing in the Kconfig process is one big BUG, and not a

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Satyam Sharma
On 5/8/07, Jeff Garzik [EMAIL PROTECTED] wrote: Satyam Sharma wrote: Yes, mixing select and depends is a recipe for build disasters. Call me a rabid fanatic, but I would in fact go as far as to say that this whole select thing in the Kconfig process is one big BUG, and not a feature. People

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Krzysztof Halasa
Roman Zippel [EMAIL PROTECTED] writes: Normal dependencies, you basically have to manually make sure they are correct (and it seems with your patch they aren't). Again, _please_ (with sugar on top) don't use select unless you have a good reason for it. You perhaps mean WAN dependency, don't

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Jeff Garzik wrote: Tough, the kernel community has voted against you. It makes far more sense to include a driver during kernel configuration, and have that driver pull in its libraries via 'select'. The lame alternative requires developers to know which libraries

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Satyam Sharma
On 5/8/07, Randy Dunlap [EMAIL PROTECTED] wrote: On Mon, 07 May 2007 16:31:48 -0400 Jeff Garzik wrote: Satyam Sharma wrote: Yes, mixing select and depends is a recipe for build disasters. Call me a rabid fanatic, but I would in fact go as far as to say that this whole select thing in the

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Randy Dunlap
Satyam Sharma wrote: On 5/8/07, Randy Dunlap [EMAIL PROTECTED] wrote: On Mon, 07 May 2007 16:31:48 -0400 Jeff Garzik wrote: Satyam Sharma wrote: Yes, mixing select and depends is a recipe for build disasters. Call me a rabid fanatic, but I would in fact go as far as to say that this

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Krzysztof Halasa
Roman Zippel [EMAIL PROTECTED] writes: What's the advantage? The HDLC option is directly before this? You don't have to know it's required, you can just select a driver for your hardware, without enabling HDLC first. -- Krzysztof Halasa - To unsubscribe from this list: send the line

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: Roman Zippel [EMAIL PROTECTED] writes: What's the advantage? The HDLC option is directly before this? You don't have to know it's required, you can just select a driver for your hardware, without enabling HDLC first. Is this a real

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Krzysztof Halasa
Roman Zippel [EMAIL PROTECTED] writes: You don't have to know it's required, you can just select a driver for your hardware, without enabling HDLC first. Is this a real problem? I think the select is better. Using select you should also consider removing HDLC as visible option and use

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: Actually I can't see any bad idea here. The original dependency was certainly, uhm, not the best one. select seriously screws with the dependencies, it's especially problematic if the selected symbol has other dependencies as HDLC in this case,

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Jeff Garzik
Roman Zippel wrote: Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: Actually I can't see any bad idea here. The original dependency was certainly, uhm, not the best one. select seriously screws with the dependencies, it's especially problematic if the selected symbol has other dependencies

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Jeff Garzik wrote: select seriously screws with the dependencies, it's especially problematic if the selected symbol has other dependencies as HDLC in this case, it makes it only more complicated to get the dependencies correct again. Please use it only if it

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-06 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Allow enabling WAN drivers without selecting generic HDLC first, > HDLC will be selected automatically. > > Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> > > diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig > index

[PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-06 Thread Krzysztof Halasa
Allow enabling WAN drivers without selecting generic HDLC first, HDLC will be selected automatically. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig index 8897f53..3a2fe82 100644 --- a/drivers/net/wan/Kconfig +++

[PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-06 Thread Krzysztof Halasa
Allow enabling WAN drivers without selecting generic HDLC first, HDLC will be selected automatically. Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED] diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig index 8897f53..3a2fe82 100644 --- a/drivers/net/wan/Kconfig +++

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-06 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: Allow enabling WAN drivers without selecting generic HDLC first, HDLC will be selected automatically. Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED] diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig index 8897f53..3a2fe82