Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-22 Thread Oded Gabbay
On 12/22/2014 11:26 AM, Oded Gabbay wrote: On 12/22/2014 10:57 AM, Christian König wrote: Am 22.12.2014 um 08:43 schrieb Oded Gabbay: On 12/22/2014 09:40 AM, Dave Airlie wrote: There should be, but when the modules are compiled in, they are loaded based on link order only, if they are in

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-22 Thread Oded Gabbay
On 12/22/2014 10:57 AM, Christian König wrote: Am 22.12.2014 um 08:43 schrieb Oded Gabbay: On 12/22/2014 09:40 AM, Dave Airlie wrote: There should be, but when the modules are compiled in, they are loaded based on link order only, if they are in the same group, and the groups are loaded by

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-22 Thread Christian König
Am 22.12.2014 um 08:43 schrieb Oded Gabbay: On 12/22/2014 09:40 AM, Dave Airlie wrote: There should be, but when the modules are compiled in, they are loaded based on link order only, if they are in the same group, and the groups are loaded by a pre-defined order. Is that really still up to

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Oded Gabbay
On 12/22/2014 09:40 AM, Dave Airlie wrote: There should be, but when the modules are compiled in, they are loaded based on link order only, if they are in the same group, and the groups are loaded by a pre-defined order. Is that really still up to date? I've seen effort to change that somethi

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Dave Airlie
> There should be, but when the modules are compiled in, they are loaded > based on > link order only, if they are in the same group, and the groups are > loaded by a > pre-defined order. Is that really still up to date? I've seen effort to change that something l

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Oded Gabbay
On 12/21/2014 06:10 PM, Christian König wrote: Am 21.12.2014 um 17:03 schrieb Oded Gabbay: On 12/21/2014 05:57 PM, Christian König wrote: There should be, but when the modules are compiled in, they are loaded based on link order only, if they are in the same group, and the groups are loaded

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Christian König
Am 21.12.2014 um 17:03 schrieb Oded Gabbay: On 12/21/2014 05:57 PM, Christian König wrote: There should be, but when the modules are compiled in, they are loaded based on link order only, if they are in the same group, and the groups are loaded by a pre-defined order. Is that really still up

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Oded Gabbay
On 12/21/2014 05:57 PM, Christian König wrote: There should be, but when the modules are compiled in, they are loaded based on link order only, if they are in the same group, and the groups are loaded by a pre-defined order. Is that really still up to date? I've seen effort to change that some

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Christian König
There should be, but when the modules are compiled in, they are loaded based on link order only, if they are in the same group, and the groups are loaded by a pre-defined order. Is that really still up to date? I've seen effort to change that something like 10+ years ago when Rusty reworked the

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Oded Gabbay
On 12/21/2014 03:06 PM, Oded Gabbay wrote: On 12/21/2014 02:19 PM, Christian König wrote: Am 21.12.2014 um 12:34 schrieb Oded Gabbay: On 12/21/2014 01:27 PM, Christian König wrote: Am 20.12.2014 um 21:46 schrieb Oded Gabbay: When amdkfd and radeon are compiled inside the kernel image (n

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Oded Gabbay
On 12/21/2014 02:19 PM, Christian König wrote: Am 21.12.2014 um 12:34 schrieb Oded Gabbay: On 12/21/2014 01:27 PM, Christian König wrote: Am 20.12.2014 um 21:46 schrieb Oded Gabbay: When amdkfd and radeon are compiled inside the kernel image (not as modules), radeon will load before amdkfd

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Christian König
Am 21.12.2014 um 12:34 schrieb Oded Gabbay: On 12/21/2014 01:27 PM, Christian König wrote: Am 20.12.2014 um 21:46 schrieb Oded Gabbay: When amdkfd and radeon are compiled inside the kernel image (not as modules), radeon will load before amdkfd and will set *kfd2kgd to its interface structure

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Christian König
Am 20.12.2014 um 21:46 schrieb Oded Gabbay: When amdkfd and radeon are compiled inside the kernel image (not as modules), radeon will load before amdkfd and will set *kfd2kgd to its interface structure. Therefore, we must not set *kfd2kgd to NULL when amdkfd is loaded because it will override rad

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Oded Gabbay
On 12/21/2014 01:27 PM, Christian König wrote: Am 20.12.2014 um 21:46 schrieb Oded Gabbay: When amdkfd and radeon are compiled inside the kernel image (not as modules), radeon will load before amdkfd and will set *kfd2kgd to its interface structure. Therefore, we must not set *kfd2kgd to NULL

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Oded Gabbay
On 12/20/2014 11:25 PM, Greg KH wrote: On Sat, Dec 20, 2014 at 10:46:12PM +0200, Oded Gabbay wrote: When amdkfd and radeon are compiled inside the kernel image (not as modules), radeon will load before amdkfd and will set *kfd2kgd to its interface structure. Therefore, we must not set *kfd2kgd

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-20 Thread Greg KH
On Sat, Dec 20, 2014 at 10:46:12PM +0200, Oded Gabbay wrote: > When amdkfd and radeon are compiled inside the kernel image (not as modules), > radeon will load before amdkfd and will set *kfd2kgd to its interface > structure. Therefore, we must not set *kfd2kgd to NULL when amdkfd is loaded > becau

[PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-20 Thread Oded Gabbay
When amdkfd and radeon are compiled inside the kernel image (not as modules), radeon will load before amdkfd and will set *kfd2kgd to its interface structure. Therefore, we must not set *kfd2kgd to NULL when amdkfd is loaded because it will override radeon's initialization and cause kernel BUG. Si