Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-17 Thread Sai Prakash Ranjan
On 1/18/2019 1:20 AM, Bjorn Andersson wrote: There seems to be some variations of this, but we try to keep everything sorted in sdm845.dtsi to avoid having to jump around between the various files. So please merge it into sdm845.dtsi (sorted by address). Sure will do it. Thanks, Sai --

Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-17 Thread Bjorn Andersson
On Tue 15 Jan 08:27 PST 2019, Sai Prakash Ranjan wrote: > Hi Bjorn, > > Thanks for the review. Please find my comments inline. > > On 1/13/2019 12:53 PM, Bjorn Andersson wrote: > > On Wed 09 Jan 09:46 PST 2019, Sai Prakash Ranjan wrote: > > > > > Add coresight components found on Qualcomm

Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-15 Thread Sai Prakash Ranjan
Hi Mathieu, On 1/14/2019 9:05 PM, Mathieu Poirier wrote: On Sat, Jan 12, 2019 at 06:21:00PM +0530, saiprakash.ran...@codeaurora.org wrote: Hi Mathieu, + + etm@704 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + arm,primecell-periphid =

Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-15 Thread Sai Prakash Ranjan
Hi Bjorn, Thanks for the review. Please find my comments inline. On 1/13/2019 12:53 PM, Bjorn Andersson wrote: On Wed 09 Jan 09:46 PST 2019, Sai Prakash Ranjan wrote: Add coresight components found on Qualcomm SDM845 SoC. Signed-off-by: Sai Prakash Ranjan Hi Sai, The content of this

Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-14 Thread Mathieu Poirier
On Sat, Jan 12, 2019 at 06:21:00PM +0530, saiprakash.ran...@codeaurora.org wrote: > Hi Mathieu, > > > > + > > > + etm@704 { > > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > > + arm,primecell-periphid = <0x000bb95d>; > > > > I'm a little curious as to why you

Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-12 Thread Bjorn Andersson
On Wed 09 Jan 09:46 PST 2019, Sai Prakash Ranjan wrote: > Add coresight components found on Qualcomm SDM845 SoC. > > Signed-off-by: Sai Prakash Ranjan Hi Sai, The content of this patch looks good, but please fold it into sdm845.dtsi (keep the nodes sorted by address). And mention below the

Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-12 Thread saiprakash . ranjan
Hi Mathieu, + + etm@704 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + arm,primecell-periphid = <0x000bb95d>; I'm a little curious as to why you need to bypass the normal AMBA bus discovery method by forcing the peripheral ID. Tracers don't

Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-11 Thread Mathieu Poirier
Hi Sai, On Wed, Jan 09, 2019 at 11:16:47PM +0530, Sai Prakash Ranjan wrote: > Add coresight components found on Qualcomm SDM845 SoC. > > Signed-off-by: Sai Prakash Ranjan > --- > .../arm64/boot/dts/qcom/sdm845-coresight.dtsi | 437 ++ > arch/arm64/boot/dts/qcom/sdm845.dtsi

[PATCH 1/3] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-09 Thread Sai Prakash Ranjan
Add coresight components found on Qualcomm SDM845 SoC. Signed-off-by: Sai Prakash Ranjan --- .../arm64/boot/dts/qcom/sdm845-coresight.dtsi | 437 ++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 + 2 files changed, 439 insertions(+) create mode 100644