Re: [PATCH 1/3] balancenuma: add stats for huge pmd numa faults

2012-11-26 Thread Hillf Danton
On 11/26/12, Mel Gorman wrote: > In my mind, the primary use of the counter is to estimate how many MB/sec > are being copied. The new counters are dropped as they help you little. Hillf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 1/3] balancenuma: add stats for huge pmd numa faults

2012-11-26 Thread Mel Gorman
On Sun, Nov 25, 2012 at 02:14:12PM +0800, Hillf Danton wrote: > On 11/24/12, Mel Gorman wrote: > > On Sat, Nov 24, 2012 at 12:17:03PM +0800, Hillf Danton wrote: > >> A thp contributes 512 times more than a regular page to numa fault stats, > >> so deserves its own vm event counter. THP migration

Re: [PATCH 1/3] balancenuma: add stats for huge pmd numa faults

2012-11-26 Thread Mel Gorman
On Sun, Nov 25, 2012 at 02:14:12PM +0800, Hillf Danton wrote: On 11/24/12, Mel Gorman mgor...@suse.de wrote: On Sat, Nov 24, 2012 at 12:17:03PM +0800, Hillf Danton wrote: A thp contributes 512 times more than a regular page to numa fault stats, so deserves its own vm event counter. THP

Re: [PATCH 1/3] balancenuma: add stats for huge pmd numa faults

2012-11-26 Thread Hillf Danton
On 11/26/12, Mel Gorman mgor...@suse.de wrote: In my mind, the primary use of the counter is to estimate how many MB/sec are being copied. The new counters are dropped as they help you little. Hillf -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH 1/3] balancenuma: add stats for huge pmd numa faults

2012-11-24 Thread Hillf Danton
On 11/24/12, Mel Gorman wrote: > On Sat, Nov 24, 2012 at 12:17:03PM +0800, Hillf Danton wrote: >> A thp contributes 512 times more than a regular page to numa fault stats, >> so deserves its own vm event counter. THP migration is also accounted. >> > > I agree and mentioned it needed fixing. I

Re: [PATCH 1/3] balancenuma: add stats for huge pmd numa faults

2012-11-24 Thread Mel Gorman
On Sat, Nov 24, 2012 at 12:17:03PM +0800, Hillf Danton wrote: > A thp contributes 512 times more than a regular page to numa fault stats, > so deserves its own vm event counter. THP migration is also accounted. > I agree and mentioned it needed fixing. I did not create a new counter but I

Re: [PATCH 1/3] balancenuma: add stats for huge pmd numa faults

2012-11-24 Thread Mel Gorman
On Sat, Nov 24, 2012 at 12:17:03PM +0800, Hillf Danton wrote: A thp contributes 512 times more than a regular page to numa fault stats, so deserves its own vm event counter. THP migration is also accounted. I agree and mentioned it needed fixing. I did not create a new counter but I properly

Re: [PATCH 1/3] balancenuma: add stats for huge pmd numa faults

2012-11-24 Thread Hillf Danton
On 11/24/12, Mel Gorman mgor...@suse.de wrote: On Sat, Nov 24, 2012 at 12:17:03PM +0800, Hillf Danton wrote: A thp contributes 512 times more than a regular page to numa fault stats, so deserves its own vm event counter. THP migration is also accounted. I agree and mentioned it needed

[PATCH 1/3] balancenuma: add stats for huge pmd numa faults

2012-11-23 Thread Hillf Danton
A thp contributes 512 times more than a regular page to numa fault stats, so deserves its own vm event counter. THP migration is also accounted. [A duplicated computation of page node idx is cleaned up] Signed-off-by: Hillf Danton --- --- a/include/linux/vm_event_item.h Fri Nov 23 21:24:12

[PATCH 1/3] balancenuma: add stats for huge pmd numa faults

2012-11-23 Thread Hillf Danton
A thp contributes 512 times more than a regular page to numa fault stats, so deserves its own vm event counter. THP migration is also accounted. [A duplicated computation of page node idx is cleaned up] Signed-off-by: Hillf Danton dhi...@gmail.com --- --- a/include/linux/vm_event_item.h Fri