Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-14 Thread Steve French
Francois Romieu wrote: Btw nobody cared about fs/cifs/connect.c::CIFSNTLMSSPNegotiateSessSetup (indentation from Mars + unchecked allocations before dereferences). -- Ueimor That routine is disabled by default (as with the SPNEGO one) so it has not gotten much attention, it will probably go

Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-14 Thread Steve French
Francois Romieu wrote: Btw nobody cared about fs/cifs/connect.c::CIFSNTLMSSPNegotiateSessSetup (indentation from Mars + unchecked allocations before dereferences). -- Ueimor That routine is disabled by default (as with the SPNEGO one) so it has not gotten much attention, it will probably go

Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-12 Thread Francois Romieu
Steve French <[EMAIL PROTECTED]> : [...] > There was a patch suggested a year or so ago to remove the older cifs > md5 implementation and have cifsencrypt.c use the newer Linux crypto > API, but since it made the code considerably more complex it did not > make any sense. The current crypto API

Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-12 Thread Jesper Juhl
er.kernel.org > Subject: Re: [PATCH 1/3] cifs: md5 cleanup - functions > > On Mon, Apr 11, 2005 at 10:11:39PM +0200, Jesper Juhl wrote: > > > > Function names and return types on same line - conform to established > > fs/cifs/ style. > > > > Patch is also

Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-12 Thread Matt Mackall
On Mon, Apr 11, 2005 at 10:11:39PM +0200, Jesper Juhl wrote: > > Function names and return types on same line - conform to established > fs/cifs/ style. > > Patch is also available at: > http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_md5-funct.patch I think the right thing to do

Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-12 Thread Matt Mackall
On Mon, Apr 11, 2005 at 10:11:39PM +0200, Jesper Juhl wrote: Function names and return types on same line - conform to established fs/cifs/ style. Patch is also available at: http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_md5-funct.patch I think the right thing to do here is

Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-12 Thread Jesper Juhl
On Mon, 11 Apr 2005, Matt Mackall wrote: Date: Mon, 11 Apr 2005 23:37:45 -0700 From: Matt Mackall [EMAIL PROTECTED] To: Jesper Juhl [EMAIL PROTECTED] Cc: Steven French [EMAIL PROTECTED], Steve French [EMAIL PROTECTED], linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] cifs: md5

Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-12 Thread Francois Romieu
Steve French [EMAIL PROTECTED] : [...] There was a patch suggested a year or so ago to remove the older cifs md5 implementation and have cifsencrypt.c use the newer Linux crypto API, but since it made the code considerably more complex it did not make any sense. The current crypto API seems to

Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-11 Thread Steve French
Alexander Nyberg <[EMAIL PROTECTED]> wrote on 04/11/2005 03:26:14 PM: > > Function names and return types on same line - conform to established > > fs/cifs/ style. > > > > -void > > -MD5Init(struct MD5Context *ctx) > > +void MD5Init(struct MD5Context *ctx) > > { > > ctx->buf[0] =

Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-11 Thread Alexander Nyberg
> Function names and return types on same line - conform to established > fs/cifs/ style. > > -void > -MD5Init(struct MD5Context *ctx) > +void MD5Init(struct MD5Context *ctx) > { > ctx->buf[0] = 0x67452301; > ctx->buf[1] = 0xefcdab89; > @@ -60,8 +58,7 @@ MD5Init(struct MD5Context

[PATCH 1/3] cifs: md5 cleanup - functions

2005-04-11 Thread Jesper Juhl
Function names and return types on same line - conform to established fs/cifs/ style. Patch is also available at: http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_md5-funct.patch Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- linux-2.6.12-rc2-mm2-orig/fs/cifs/md5.c

[PATCH 1/3] cifs: md5 cleanup - functions

2005-04-11 Thread Jesper Juhl
Function names and return types on same line - conform to established fs/cifs/ style. Patch is also available at: http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_md5-funct.patch Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- linux-2.6.12-rc2-mm2-orig/fs/cifs/md5.c

Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-11 Thread Alexander Nyberg
Function names and return types on same line - conform to established fs/cifs/ style. -void -MD5Init(struct MD5Context *ctx) +void MD5Init(struct MD5Context *ctx) { ctx-buf[0] = 0x67452301; ctx-buf[1] = 0xefcdab89; @@ -60,8 +58,7 @@ MD5Init(struct MD5Context *ctx) *

Re: [PATCH 1/3] cifs: md5 cleanup - functions

2005-04-11 Thread Steve French
Alexander Nyberg [EMAIL PROTECTED] wrote on 04/11/2005 03:26:14 PM: Function names and return types on same line - conform to established fs/cifs/ style. -void -MD5Init(struct MD5Context *ctx) +void MD5Init(struct MD5Context *ctx) { ctx-buf[0] = 0x67452301; ctx-buf[1]