Re: [PATCH 1/3] drivers-core: make structured logging play nice with dynamic-debug

2012-07-23 Thread Jim Cromie
On Mon, Jul 23, 2012 at 11:09 AM, Joe Perches wrote: > On Mon, 2012-07-23 at 09:07 -0400, Jason Baron wrote: >> On Thu, Jul 19, 2012 at 01:46:20PM -0600, Jim Cromie wrote: >> > commit c4e00daaa96d3a0786f1f4fe6456281c60ef9a16 changed __dev_printk >> > in a way that broke dynamic-debug's ability to

Re: [PATCH 1/3] drivers-core: make structured logging play nice with dynamic-debug

2012-07-23 Thread Joe Perches
On Mon, 2012-07-23 at 09:07 -0400, Jason Baron wrote: > On Thu, Jul 19, 2012 at 01:46:20PM -0600, Jim Cromie wrote: > > commit c4e00daaa96d3a0786f1f4fe6456281c60ef9a16 changed __dev_printk > > in a way that broke dynamic-debug's ability to control the dynamic > > prefix of dev_dbg(dev,..), but not

Re: [PATCH 1/3] drivers-core: make structured logging play nice with dynamic-debug

2012-07-23 Thread Jason Baron
On Thu, Jul 19, 2012 at 01:46:20PM -0600, Jim Cromie wrote: > commit c4e00daaa96d3a0786f1f4fe6456281c60ef9a16 changed __dev_printk > in a way that broke dynamic-debug's ability to control the dynamic > prefix of dev_dbg(dev,..), but not dev_dbg(NULL,..) or pr_debug(..), > which is why it wasnt

Re: [PATCH 1/3] drivers-core: make structured logging play nice with dynamic-debug

2012-07-23 Thread Jason Baron
On Thu, Jul 19, 2012 at 01:46:20PM -0600, Jim Cromie wrote: commit c4e00daaa96d3a0786f1f4fe6456281c60ef9a16 changed __dev_printk in a way that broke dynamic-debug's ability to control the dynamic prefix of dev_dbg(dev,..), but not dev_dbg(NULL,..) or pr_debug(..), which is why it wasnt noticed

Re: [PATCH 1/3] drivers-core: make structured logging play nice with dynamic-debug

2012-07-23 Thread Joe Perches
On Mon, 2012-07-23 at 09:07 -0400, Jason Baron wrote: On Thu, Jul 19, 2012 at 01:46:20PM -0600, Jim Cromie wrote: commit c4e00daaa96d3a0786f1f4fe6456281c60ef9a16 changed __dev_printk in a way that broke dynamic-debug's ability to control the dynamic prefix of dev_dbg(dev,..), but not

Re: [PATCH 1/3] drivers-core: make structured logging play nice with dynamic-debug

2012-07-23 Thread Jim Cromie
On Mon, Jul 23, 2012 at 11:09 AM, Joe Perches j...@perches.com wrote: On Mon, 2012-07-23 at 09:07 -0400, Jason Baron wrote: On Thu, Jul 19, 2012 at 01:46:20PM -0600, Jim Cromie wrote: commit c4e00daaa96d3a0786f1f4fe6456281c60ef9a16 changed __dev_printk in a way that broke dynamic-debug's

[PATCH 1/3] drivers-core: make structured logging play nice with dynamic-debug

2012-07-19 Thread Jim Cromie
commit c4e00daaa96d3a0786f1f4fe6456281c60ef9a16 changed __dev_printk in a way that broke dynamic-debug's ability to control the dynamic prefix of dev_dbg(dev,..), but not dev_dbg(NULL,..) or pr_debug(..), which is why it wasnt noticed sooner. When dev==NULL, __dev_printk() just calls printk(),

[PATCH 1/3] drivers-core: make structured logging play nice with dynamic-debug

2012-07-19 Thread Jim Cromie
commit c4e00daaa96d3a0786f1f4fe6456281c60ef9a16 changed __dev_printk in a way that broke dynamic-debug's ability to control the dynamic prefix of dev_dbg(dev,..), but not dev_dbg(NULL,..) or pr_debug(..), which is why it wasnt noticed sooner. When dev==NULL, __dev_printk() just calls printk(),

[PATCH 1/3] drivers-core: make structured logging play nice with dynamic-debug

2012-07-19 Thread Jim Cromie
commit c4e00daaa96d3a0786f1f4fe6456281c60ef9a16 changed __dev_printk in a way that broke dynamic-debug's ability to control the dynamic prefix of dev_dbg(dev,..), but not dev_dbg(NULL,..) or pr_debug(..), which is why it wasnt noticed sooner. When dev==NULL, __dev_printk() just calls printk(),

[PATCH 1/3] drivers-core: make structured logging play nice with dynamic-debug

2012-07-19 Thread Jim Cromie
commit c4e00daaa96d3a0786f1f4fe6456281c60ef9a16 changed __dev_printk in a way that broke dynamic-debug's ability to control the dynamic prefix of dev_dbg(dev,..), but not dev_dbg(NULL,..) or pr_debug(..), which is why it wasnt noticed sooner. When dev==NULL, __dev_printk() just calls printk(),