Re: [PATCH 1/3] gpio: 74xx: fix a possible NULL dereference

2015-11-30 Thread Linus Walleij
On Fri, Nov 20, 2015 at 10:22 AM, Geert Uytterhoeven wrote: > On Wed, Nov 11, 2015 at 9:27 PM, LABBE Corentin > wrote: >> of_match_device could return NULL, and so cause a NULL pointer >> dereference later at line 132: >> priv->flags = (uintptr_t) of_id->data; >> >> Reported-by: coverity (CID 132

Re: [PATCH 1/3] gpio: 74xx: fix a possible NULL dereference

2015-11-20 Thread Geert Uytterhoeven
On Wed, Nov 11, 2015 at 9:27 PM, LABBE Corentin wrote: > of_match_device could return NULL, and so cause a NULL pointer > dereference later at line 132: > priv->flags = (uintptr_t) of_id->data; > > Reported-by: coverity (CID 1324141) This is a DT-only driver, hence this cannot happen? > Signed-o

Re: [PATCH 1/3] gpio: 74xx: fix a possible NULL dereference

2015-11-17 Thread Linus Walleij
On Wed, Nov 11, 2015 at 9:27 PM, LABBE Corentin wrote: > of_match_device could return NULL, and so cause a NULL pointer > dereference later at line 132: > priv->flags = (uintptr_t) of_id->data; > > Reported-by: coverity (CID 1324141) > Signed-off-by: LABBE Corentin Patch applied. Yours, Linus

[PATCH 1/3] gpio: 74xx: fix a possible NULL dereference

2015-11-11 Thread LABBE Corentin
of_match_device could return NULL, and so cause a NULL pointer dereference later at line 132: priv->flags = (uintptr_t) of_id->data; Reported-by: coverity (CID 1324141) Signed-off-by: LABBE Corentin --- drivers/gpio/gpio-74xx-mmio.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) d