Re: [PATCH 1/3] lib: crc32: Greatly shrink CRC combining code

2014-06-04 Thread George Spelvin
>>> Perhaps a newline here. >> Question: where do you think a newline should go? It's not obvious >> to me. My style has been to keep as much of a declaration on one line >> as possible so "git grep include" is as informative as possible. > It's just nit, but since you've asked, end result

Re: [PATCH 1/3] lib: crc32: Greatly shrink CRC combining code

2014-06-04 Thread Daniel Borkmann
On 06/04/2014 08:32 PM, George Spelvin wrote: Thanks for the nitpicks! I think you might want to cc Andrew Morton to let this go via akpm's tree for misc changes, perhaps? I don't care, but akpm is fine by me. I'll send out a v2 after I resolve one minor point with you; see below. Once

Re: [PATCH 1/3] lib: crc32: Greatly shrink CRC combining code

2014-06-04 Thread George Spelvin
Thanks for the nitpicks! > I think you might want to cc Andrew Morton > to let this go via akpm's tree for misc changes, perhaps? I don't care, but akpm is fine by me. I'll send out a v2 after I resolve one minor point with you; see below. Once that's done, may I add a Reviewed-by: or

Re: [PATCH 1/3] lib: crc32: Greatly shrink CRC combining code

2014-06-04 Thread Daniel Borkmann
Sorry for the late answer, this slipped somehow through ... I think you might want to cc Andrew Morton to let this go via akpm's tree for misc changes, perhaps? The work from my side went via Dave's net-next tree as it had some follow-up SCTP work that depended on these below bits. No

Re: [PATCH 1/3] lib: crc32: Greatly shrink CRC combining code

2014-06-04 Thread Daniel Borkmann
Sorry for the late answer, this slipped somehow through ... I think you might want to cc Andrew Morton a...@linux-foundation.org to let this go via akpm's tree for misc changes, perhaps? The work from my side went via Dave's net-next tree as it had some follow-up SCTP work that depended on

Re: [PATCH 1/3] lib: crc32: Greatly shrink CRC combining code

2014-06-04 Thread George Spelvin
Thanks for the nitpicks! I think you might want to cc Andrew Morton a...@linux-foundation.org to let this go via akpm's tree for misc changes, perhaps? I don't care, but akpm is fine by me. I'll send out a v2 after I resolve one minor point with you; see below. Once that's done, may I add a

Re: [PATCH 1/3] lib: crc32: Greatly shrink CRC combining code

2014-06-04 Thread Daniel Borkmann
On 06/04/2014 08:32 PM, George Spelvin wrote: Thanks for the nitpicks! I think you might want to cc Andrew Morton a...@linux-foundation.org to let this go via akpm's tree for misc changes, perhaps? I don't care, but akpm is fine by me. I'll send out a v2 after I resolve one minor point with

Re: [PATCH 1/3] lib: crc32: Greatly shrink CRC combining code

2014-06-04 Thread George Spelvin
Perhaps a newline here. Question: where do you think a newline should go? It's not obvious to me. My style has been to keep as much of a declaration on one line as possible so git grep function include is as informative as possible. It's just nit, but since you've asked, end result like

[PATCH 1/3] lib: crc32: Greatly shrink CRC combining code

2014-05-29 Thread George Spelvin
There's no need for a full 32x32 matrix, when rows before the last are just shifted copies of the rows after them. There's still room for improvement (especially on X86 processors with CRC32 and PCLMUL instructions), but this is a large step in the right direction. The internal primitive is now

[PATCH 1/3] lib: crc32: Greatly shrink CRC combining code

2014-05-29 Thread George Spelvin
There's no need for a full 32x32 matrix, when rows before the last are just shifted copies of the rows after them. There's still room for improvement (especially on X86 processors with CRC32 and PCLMUL instructions), but this is a large step in the right direction. The internal primitive is now