On Mon, Jan 20, 2014 at 04:55:52PM +0800, Roger wrote:
> On 01/16/2014 05:35 PM, Lee Jones wrote:
> +static int rtsx_usb_bulk_transfer_sglist(struct rtsx_ucr *ucr,
> + unsigned int pipe, struct scatterlist *sg, int num_sg,
> + unsigned int length, unsigned int
On 01/16/2014 05:35 PM, Lee Jones wrote:
+static int rtsx_usb_bulk_transfer_sglist(struct rtsx_ucr *ucr,
+ unsigned int pipe, struct scatterlist *sg, int num_sg,
+ unsigned int length, unsigned int *act_len, int timeout)
+{
+ int ret;
+
+ dev_dbg(>pusb_intf->dev,
On Mon, Jan 20, 2014 at 04:55:52PM +0800, Roger wrote:
On 01/16/2014 05:35 PM, Lee Jones wrote:
+static int rtsx_usb_bulk_transfer_sglist(struct rtsx_ucr *ucr,
+ unsigned int pipe, struct scatterlist *sg, int num_sg,
+ unsigned int length, unsigned int *act_len, int
On 01/16/2014 05:35 PM, Lee Jones wrote:
+static int rtsx_usb_bulk_transfer_sglist(struct rtsx_ucr *ucr,
+ unsigned int pipe, struct scatterlist *sg, int num_sg,
+ unsigned int length, unsigned int *act_len, int timeout)
+{
+ int ret;
+
+
> >>+static int rtsx_usb_bulk_transfer_sglist(struct rtsx_ucr *ucr,
> >>+ unsigned int pipe, struct scatterlist *sg, int num_sg,
> >>+ unsigned int length, unsigned int *act_len, int timeout)
> >>+{
> >>+ int ret;
> >>+
> >>+ dev_dbg(>pusb_intf->dev, "%s: xfer %u
On 01/14/2014 09:04 PM, Lee Jones wrote:
From: Roger Tseng
Realtek USB card reader provides a channel to transfer command or data to flash
memory cards. This driver exports host instances for mmc and memstick subsystems
and handles basic works.
Signed-off-by: Roger Tseng
[snip]
+static
On 01/14/2014 09:04 PM, Lee Jones wrote:
From: Roger Tseng rogera...@realtek.com
Realtek USB card reader provides a channel to transfer command or data to flash
memory cards. This driver exports host instances for mmc and memstick subsystems
and handles basic works.
Signed-off-by: Roger Tseng
+static int rtsx_usb_bulk_transfer_sglist(struct rtsx_ucr *ucr,
+ unsigned int pipe, struct scatterlist *sg, int num_sg,
+ unsigned int length, unsigned int *act_len, int timeout)
+{
+ int ret;
+
+ dev_dbg(ucr-pusb_intf-dev, %s: xfer %u bytes, %d entries\n,
On Tue, Jan 14, 2014 at 03:47:34PM +0800, rogera...@realtek.com wrote:
> From: Roger Tseng
>
> Realtek USB card reader provides a channel to transfer command or data to
> flash
> memory cards. This driver exports host instances for mmc and memstick
> subsystems
> and handles basic works.
>
>
> [ Sorry, I am coming down with the flu today so I'm doing dorky things
> like reviewing review comments. I'm not sure how coherent I am. ]
Always welcome.
NB: I did this review in double-quick time, which may account for some
of the weird thought processes (or lack there of).
> > >
On Tue, Jan 14, 2014 at 04:46:34PM +0300, Dan Carpenter wrote:
> [ Sorry, I am coming down with the flu today so I'm doing dorky things
> like reviewing review comments. I'm not sure how coherent I am. ]
>
> On Tue, Jan 14, 2014 at 01:04:09PM +, Lee Jones wrote:
>
> > > +static void
[ Sorry, I am coming down with the flu today so I'm doing dorky things
like reviewing review comments. I'm not sure how coherent I am. ]
On Tue, Jan 14, 2014 at 01:04:09PM +, Lee Jones wrote:
> > +static void rtsx_usb_sg_timed_out(unsigned long data)
> > +{
> > + struct rtsx_ucr *ucr
> From: Roger Tseng
>
> Realtek USB card reader provides a channel to transfer command or data to
> flash
> memory cards. This driver exports host instances for mmc and memstick
> subsystems
> and handles basic works.
>
> Signed-off-by: Roger Tseng
> ---
> drivers/mfd/Kconfig | 10
From: Roger Tseng rogera...@realtek.com
Realtek USB card reader provides a channel to transfer command or data to
flash
memory cards. This driver exports host instances for mmc and memstick
subsystems
and handles basic works.
Signed-off-by: Roger Tseng rogera...@realtek.com
---
[ Sorry, I am coming down with the flu today so I'm doing dorky things
like reviewing review comments. I'm not sure how coherent I am. ]
On Tue, Jan 14, 2014 at 01:04:09PM +, Lee Jones wrote:
+static void rtsx_usb_sg_timed_out(unsigned long data)
+{
+ struct rtsx_ucr *ucr =
On Tue, Jan 14, 2014 at 04:46:34PM +0300, Dan Carpenter wrote:
[ Sorry, I am coming down with the flu today so I'm doing dorky things
like reviewing review comments. I'm not sure how coherent I am. ]
On Tue, Jan 14, 2014 at 01:04:09PM +, Lee Jones wrote:
+static void
[ Sorry, I am coming down with the flu today so I'm doing dorky things
like reviewing review comments. I'm not sure how coherent I am. ]
Always welcome.
NB: I did this review in double-quick time, which may account for some
of the weird thought processes (or lack there of).
+static
On Tue, Jan 14, 2014 at 03:47:34PM +0800, rogera...@realtek.com wrote:
From: Roger Tseng rogera...@realtek.com
Realtek USB card reader provides a channel to transfer command or data to
flash
memory cards. This driver exports host instances for mmc and memstick
subsystems
and handles
From: Roger Tseng
Realtek USB card reader provides a channel to transfer command or data to flash
memory cards. This driver exports host instances for mmc and memstick subsystems
and handles basic works.
Signed-off-by: Roger Tseng
---
drivers/mfd/Kconfig | 10 +
drivers/mfd/Makefile
From: Roger Tseng rogera...@realtek.com
Realtek USB card reader provides a channel to transfer command or data to flash
memory cards. This driver exports host instances for mmc and memstick subsystems
and handles basic works.
Signed-off-by: Roger Tseng rogera...@realtek.com
---
On Mon, 2013-12-23 at 17:52 +0800, rogera...@realtek.com wrote:
> From: Roger Tseng
>
> Realtek USB card reader provides a channel to transfer command or data to
> flash
> memory cards. This driver exports host instances for mmc and memstick
> subsystems
> and handles basic works.
Thank you
On Mon, 2013-12-23 at 17:52 +0800, rogera...@realtek.com wrote:
From: Roger Tseng rogera...@realtek.com
Realtek USB card reader provides a channel to transfer command or data to
flash
memory cards. This driver exports host instances for mmc and memstick
subsystems
and handles basic
On Wed, Jan 08, 2014 at 03:56:05PM +0800, Roger Tseng wrote:
> Hi Dan,
>
> >> +int rtsx_usb_ep0_write_register(struct rtsx_ucr *ucr, u16 addr,
> >> + u8 mask, u8 data)
> >> +{
> >> + u16 value = 0, index = 0;
> >> +
> >> + value |= (u16)(3 & 0x03) << 14;
> >> + value |=
On Wed, Jan 08, 2014 at 03:56:05PM +0800, Roger Tseng wrote:
Hi Dan,
+int rtsx_usb_ep0_write_register(struct rtsx_ucr *ucr, u16 addr,
+ u8 mask, u8 data)
+{
+ u16 value = 0, index = 0;
+
+ value |= (u16)(3 0x03) 14;
+ value |= (u16)(addr 0x3FFF);
Hi Dan,
>> +int rtsx_usb_ep0_write_register(struct rtsx_ucr *ucr, u16 addr,
>> + u8 mask, u8 data)
>> +{
>> + u16 value = 0, index = 0;
>> +
>> + value |= (u16)(3 & 0x03) << 14;
>> + value |= (u16)(addr & 0x3FFF);
>
>Don't do pointless things:
>
>value |= 0x03 <<
Hi Dan,
+int rtsx_usb_ep0_write_register(struct rtsx_ucr *ucr, u16 addr,
+ u8 mask, u8 data)
+{
+ u16 value = 0, index = 0;
+
+ value |= (u16)(3 0x03) 14;
+ value |= (u16)(addr 0x3FFF);
Don't do pointless things:
value |= 0x03 14;
value |= addr
On Mon, Dec 23, 2013 at 05:52:05PM +0800, rogera...@realtek.com wrote:
> +static int rtsx_usb_seq_write_register(struct rtsx_ucr *ucr,
> + u16 addr, u16 len, u8 *data)
> +{
> + u16 cmd_len = len + 12;
> +
> + if (data == NULL)
> + return -EINVAL;
> +
> + cmd_len
On Mon, Dec 23, 2013 at 05:52:05PM +0800, rogera...@realtek.com wrote:
+static int rtsx_usb_seq_write_register(struct rtsx_ucr *ucr,
+ u16 addr, u16 len, u8 *data)
+{
+ u16 cmd_len = len + 12;
+
+ if (data == NULL)
+ return -EINVAL;
+
+ cmd_len =
From: Roger Tseng
Realtek USB card reader provides a channel to transfer command or data to flash
memory cards. This driver exports host instances for mmc and memstick subsystems
and handles basic works.
Signed-off-by: Roger Tseng
---
drivers/mfd/Kconfig | 10 +
drivers/mfd/Makefile
From: Roger Tseng rogera...@realtek.com
Realtek USB card reader provides a channel to transfer command or data to flash
memory cards. This driver exports host instances for mmc and memstick subsystems
and handles basic works.
Signed-off-by: Roger Tseng rogera...@realtek.com
---
30 matches
Mail list logo