On Tue, 17 Jul 2012, JoonSoo Kim wrote:
> > Actually, it makes me wonder if there is any code that uses this
> > information. If not, it would be best in my opinion to make it return
> > zero or negative error code, but that would have to be checked.
>
> I think that, too.
> I looked at every
2012/7/17 Michal Nazarewicz :
> Acked-by: Michal Nazarewicz
Thanks.
> Actually, it makes me wonder if there is any code that uses this
> information. If not, it would be best in my opinion to make it return
> zero or negative error code, but that would have to be checked.
I think that, too.
I
Joonsoo Kim writes:
> migrate_pages() should return number of pages not migrated or error code.
> When unmap_and_move return -EAGAIN, outer loop is re-execution without
> initialising nr_failed. This makes nr_failed over-counted.
>
> So this patch correct it by initialising nr_failed in outer
On Tue, 17 Jul 2012, JoonSoo Kim wrote:
>
> for (pass = 0; pass < 10 && retry; pass++) {
> retry = 0;
> + nr_failed = 0;
>
> list_for_each_entry_safe(page, page2, from, lru) {
> cond_resched();
>
> When I resend with
2012/7/17 Christoph Lameter :
> On Tue, 17 Jul 2012, Joonsoo Kim wrote:
>
>> migrate_pages() should return number of pages not migrated or error code.
>> When unmap_and_move return -EAGAIN, outer loop is re-execution without
>> initialising nr_failed. This makes nr_failed over-counted.
>
> The
On Tue, 17 Jul 2012, Joonsoo Kim wrote:
> migrate_pages() should return number of pages not migrated or error code.
> When unmap_and_move return -EAGAIN, outer loop is re-execution without
> initialising nr_failed. This makes nr_failed over-counted.
The itention of the nr_failed was only to give
migrate_pages() should return number of pages not migrated or error code.
When unmap_and_move return -EAGAIN, outer loop is re-execution without
initialising nr_failed. This makes nr_failed over-counted.
So this patch correct it by initialising nr_failed in outer loop.
Signed-off-by: Joonsoo Kim
migrate_pages() should return number of pages not migrated or error code.
When unmap_and_move return -EAGAIN, outer loop is re-execution without
initialising nr_failed. This makes nr_failed over-counted.
So this patch correct it by initialising nr_failed in outer loop.
Signed-off-by: Joonsoo Kim
On Tue, 17 Jul 2012, Joonsoo Kim wrote:
migrate_pages() should return number of pages not migrated or error code.
When unmap_and_move return -EAGAIN, outer loop is re-execution without
initialising nr_failed. This makes nr_failed over-counted.
The itention of the nr_failed was only to give an
2012/7/17 Christoph Lameter c...@linux.com:
On Tue, 17 Jul 2012, Joonsoo Kim wrote:
migrate_pages() should return number of pages not migrated or error code.
When unmap_and_move return -EAGAIN, outer loop is re-execution without
initialising nr_failed. This makes nr_failed over-counted.
The
On Tue, 17 Jul 2012, JoonSoo Kim wrote:
for (pass = 0; pass 10 retry; pass++) {
retry = 0;
+ nr_failed = 0;
list_for_each_entry_safe(page, page2, from, lru) {
cond_resched();
When I resend with this, could I
Joonsoo Kim js1...@gmail.com writes:
migrate_pages() should return number of pages not migrated or error code.
When unmap_and_move return -EAGAIN, outer loop is re-execution without
initialising nr_failed. This makes nr_failed over-counted.
So this patch correct it by initialising nr_failed
2012/7/17 Michal Nazarewicz min...@tlen.pl:
Acked-by: Michal Nazarewicz min...@mina86.com
Thanks.
Actually, it makes me wonder if there is any code that uses this
information. If not, it would be best in my opinion to make it return
zero or negative error code, but that would have to be
On Tue, 17 Jul 2012, JoonSoo Kim wrote:
Actually, it makes me wonder if there is any code that uses this
information. If not, it would be best in my opinion to make it return
zero or negative error code, but that would have to be checked.
I think that, too.
I looked at every callsites
14 matches
Mail list logo
