Re: [PATCH 1/3] mm: thp: make deferred split shrinker memcg aware

2019-06-13 Thread Yang Shi
On 6/13/19 1:19 AM, Kirill Tkhai wrote: On 10.06.2019 20:25, Yang Shi wrote: On 6/10/19 1:23 AM, Kirill Tkhai wrote: On 29.05.2019 14:25, Yang Shi wrote: On 5/29/19 4:14 PM, Kirill Tkhai wrote: On 29.05.2019 05:43, Yang Shi wrote: On 5/28/19 10:42 PM, Kirill Tkhai wrote: Hi, Yang, On

Re: [PATCH 1/3] mm: thp: make deferred split shrinker memcg aware

2019-06-13 Thread Kirill Tkhai
On 10.06.2019 20:25, Yang Shi wrote: > > > On 6/10/19 1:23 AM, Kirill Tkhai wrote: >> On 29.05.2019 14:25, Yang Shi wrote: >>> >>> On 5/29/19 4:14 PM, Kirill Tkhai wrote: On 29.05.2019 05:43, Yang Shi wrote: > On 5/28/19 10:42 PM, Kirill Tkhai wrote: >> Hi, Yang, >> >> On

Re: [PATCH 1/3] mm: thp: make deferred split shrinker memcg aware

2019-06-10 Thread Yang Shi
On 6/10/19 1:23 AM, Kirill Tkhai wrote: On 29.05.2019 14:25, Yang Shi wrote: On 5/29/19 4:14 PM, Kirill Tkhai wrote: On 29.05.2019 05:43, Yang Shi wrote: On 5/28/19 10:42 PM, Kirill Tkhai wrote: Hi, Yang, On 28.05.2019 15:44, Yang Shi wrote: Currently THP deferred split shrinker is not

Re: [PATCH 1/3] mm: thp: make deferred split shrinker memcg aware

2019-06-10 Thread Kirill Tkhai
On 29.05.2019 14:25, Yang Shi wrote: > > > On 5/29/19 4:14 PM, Kirill Tkhai wrote: >> On 29.05.2019 05:43, Yang Shi wrote: >>> >>> On 5/28/19 10:42 PM, Kirill Tkhai wrote: Hi, Yang, On 28.05.2019 15:44, Yang Shi wrote: > Currently THP deferred split shrinker is not memcg

Re: [PATCH 1/3] mm: thp: make deferred split shrinker memcg aware

2019-05-30 Thread Yang Shi
On 5/30/19 8:07 PM, Kirill A. Shutemov wrote: On Tue, May 28, 2019 at 08:44:22PM +0800, Yang Shi wrote: diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index bc74d6a..9ff5fab 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -316,6 +316,12 @@

Re: [PATCH 1/3] mm: thp: make deferred split shrinker memcg aware

2019-05-30 Thread Kirill A. Shutemov
On Tue, May 28, 2019 at 08:44:22PM +0800, Yang Shi wrote: > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index bc74d6a..9ff5fab 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -316,6 +316,12 @@ struct mem_cgroup { > struct list_head

Re: [PATCH 1/3] mm: thp: make deferred split shrinker memcg aware

2019-05-29 Thread Yang Shi
On 5/29/19 4:14 PM, Kirill Tkhai wrote: On 29.05.2019 05:43, Yang Shi wrote: On 5/28/19 10:42 PM, Kirill Tkhai wrote: Hi, Yang, On 28.05.2019 15:44, Yang Shi wrote: Currently THP deferred split shrinker is not memcg aware, this may cause premature OOM with some configuration. For example

Re: [PATCH 1/3] mm: thp: make deferred split shrinker memcg aware

2019-05-29 Thread Kirill Tkhai
On 29.05.2019 05:43, Yang Shi wrote: > > > On 5/28/19 10:42 PM, Kirill Tkhai wrote: >> Hi, Yang, >> >> On 28.05.2019 15:44, Yang Shi wrote: >>> Currently THP deferred split shrinker is not memcg aware, this may cause >>> premature OOM with some configuration. For example the below test would >>>

Re: [PATCH 1/3] mm: thp: make deferred split shrinker memcg aware

2019-05-28 Thread Yang Shi
On 5/28/19 10:42 PM, Kirill Tkhai wrote: Hi, Yang, On 28.05.2019 15:44, Yang Shi wrote: Currently THP deferred split shrinker is not memcg aware, this may cause premature OOM with some configuration. For example the below test would run into premature OOM easily: $ cgcreate -g memory:thp $

Re: [PATCH 1/3] mm: thp: make deferred split shrinker memcg aware

2019-05-28 Thread Kirill Tkhai
Hi, Yang, On 28.05.2019 15:44, Yang Shi wrote: > Currently THP deferred split shrinker is not memcg aware, this may cause > premature OOM with some configuration. For example the below test would > run into premature OOM easily: > > $ cgcreate -g memory:thp > $ echo 4G >

[PATCH 1/3] mm: thp: make deferred split shrinker memcg aware

2019-05-28 Thread Yang Shi
Currently THP deferred split shrinker is not memcg aware, this may cause premature OOM with some configuration. For example the below test would run into premature OOM easily: $ cgcreate -g memory:thp $ echo 4G > /sys/fs/cgroup/memory/thp/memory/limit_in_bytes $ cgexec -g memory:thp