Re: [PATCH 1/3] modinst: wrap long lines in order to enhance cmd_modules_install

2014-08-20 Thread Rusty Russell
Jim Davis writes: > On Tue, Aug 19, 2014 at 11:57 AM, Bertrand Jacquin wrote: >> Note: shouldn't we use 'install -D $(2)/$@ $@' instead of mkdir >> and cp ? > > Will an install with -D in that sense always be available? That's not > a flag in the original (BSD) program, and I did find one SPARC

Re: [PATCH 1/3] modinst: wrap long lines in order to enhance cmd_modules_install

2014-08-20 Thread Rusty Russell
Jim Davis jim.ep...@gmail.com writes: On Tue, Aug 19, 2014 at 11:57 AM, Bertrand Jacquin be...@meleeweb.net wrote: Note: shouldn't we use 'install -D $(2)/$@ $@' instead of mkdir and cp ? Will an install with -D in that sense always be available? That's not a flag in the original (BSD)

Re: [PATCH 1/3] modinst: wrap long lines in order to enhance cmd_modules_install

2014-08-19 Thread Jim Davis
On Tue, Aug 19, 2014 at 11:57 AM, Bertrand Jacquin wrote: > Note: shouldn't we use 'install -D $(2)/$@ $@' instead of mkdir > and cp ? Will an install with -D in that sense always be available? That's not a flag in the original (BSD) program, and I did find one SPARC system -- admittedly an

[PATCH 1/3] modinst: wrap long lines in order to enhance cmd_modules_install

2014-08-19 Thread Bertrand Jacquin
Note: shouldn't we use 'install -D $(2)/$@ $@' instead of mkdir and cp ? Reviewed-by: Willy Tarreau Signed-off-by: Bertrand Jacquin --- scripts/Makefile.modinst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index

Re: [PATCH 1/3] modinst: wrap long lines in order to enhance cmd_modules_install

2014-08-19 Thread Jim Davis
On Tue, Aug 19, 2014 at 11:57 AM, Bertrand Jacquin be...@meleeweb.net wrote: Note: shouldn't we use 'install -D $(2)/$@ $@' instead of mkdir and cp ? Will an install with -D in that sense always be available? That's not a flag in the original (BSD) program, and I did find one SPARC system --

[PATCH 1/3] modinst: wrap long lines in order to enhance cmd_modules_install

2014-08-19 Thread Bertrand Jacquin
Note: shouldn't we use 'install -D $(2)/$@ $@' instead of mkdir and cp ? Reviewed-by: Willy Tarreau w...@1wt.eu Signed-off-by: Bertrand Jacquin be...@meleeweb.net --- scripts/Makefile.modinst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst

[PATCH 1/3] modinst: wrap long lines in order to enhance cmd_modules_install

2014-08-16 Thread Bertrand Jacquin
Note: shouldn't we use 'install -D $(2)/$@ $@' instead of mkdir and cp ? Reviewed-by: Willy Tarreau Signed-off-by: Bertrand Jacquin --- scripts/Makefile.modinst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index

[PATCH 1/3] modinst: wrap long lines in order to enhance cmd_modules_install

2014-08-16 Thread Bertrand Jacquin
Note: shouldn't we use 'install -D $(2)/$@ $@' instead of mkdir and cp ? Reviewed-by: Willy Tarreau w...@1wt.eu Signed-off-by: Bertrand Jacquin be...@meleeweb.net --- scripts/Makefile.modinst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst