> "Calvin" == Calvin Owens writes:
Calvin> This flag that conditionally acquires the mutex is confusing and
Calvin> prone to bugginess: refactor it into two separate function
Calvin> calls, and make the unlocked one complain if it's called outside
Calvin> the mutex.
> "Calvin" == Calvin Owens writes:
Calvin> This flag that conditionally acquires the mutex is confusing and
Calvin> prone to bugginess: refactor it into two separate function
Calvin> calls, and make the unlocked one complain if it's called outside
Calvin> the mutex.
Applied to
tomley; Martin K. Petersen
Cc: mpt-fusionlinux@broadcom.com; linux-s...@vger.kernel.org;
linux-kernel@vger.kernel.org; kernel-t...@fb.com; Calvin Owens
Subject: [PATCH 1/3] mpt3sas: Eliminate conditional locking in
mpt3sas_scsih_issue_tm()
This flag that conditionally acquires the mutex is con
-fusionlinux@broadcom.com; linux-s...@vger.kernel.org;
linux-kernel@vger.kernel.org; kernel-t...@fb.com; Calvin Owens
Subject: [PATCH 1/3] mpt3sas: Eliminate conditional locking in
mpt3sas_scsih_issue_tm()
This flag that conditionally acquires the mutex is confusing and prone to
bugginess
This flag that conditionally acquires the mutex is confusing and prone
to bugginess: refactor it into two separate function calls, and make
the unlocked one complain if it's called outside the mutex.
Signed-off-by: Calvin Owens
---
drivers/scsi/mpt3sas/mpt3sas_base.h | 16
This flag that conditionally acquires the mutex is confusing and prone
to bugginess: refactor it into two separate function calls, and make
the unlocked one complain if it's called outside the mutex.
Signed-off-by: Calvin Owens
---
drivers/scsi/mpt3sas/mpt3sas_base.h | 16 +++--
6 matches
Mail list logo