Re: [PATCH 1/3] mtd: nand: raw: brcmnand: Refactored code and introduced inline functions

2019-06-03 Thread Kamal Dasu
On Mon, Jun 3, 2019 at 10:18 AM Boris Brezillon wrote: > > On Mon, 3 Jun 2019 10:11:20 -0400 > Kamal Dasu wrote: > > > Boris, > > > > On Sat, Jun 1, 2019 at 3:57 AM Boris Brezillon > > wrote: > > > > > > On Thu, 30 May 2019 17:20:35 -0400 > > > Kamal Dasu wrote: > > > > > > > Refactored NAND

Re: [PATCH 1/3] mtd: nand: raw: brcmnand: Refactored code and introduced inline functions

2019-06-03 Thread Boris Brezillon
On Mon, 3 Jun 2019 10:11:20 -0400 Kamal Dasu wrote: > Boris, > > On Sat, Jun 1, 2019 at 3:57 AM Boris Brezillon > wrote: > > > > On Thu, 30 May 2019 17:20:35 -0400 > > Kamal Dasu wrote: > > > > > Refactored NAND ECC and CMD address configuration code to use inline > > > functions. > > > >

Re: [PATCH 1/3] mtd: nand: raw: brcmnand: Refactored code and introduced inline functions

2019-06-03 Thread Kamal Dasu
Boris, On Sat, Jun 1, 2019 at 3:57 AM Boris Brezillon wrote: > > On Thu, 30 May 2019 17:20:35 -0400 > Kamal Dasu wrote: > > > Refactored NAND ECC and CMD address configuration code to use inline > > functions. > > I'd expect the compiler to be smart enough to decide when inlining is >

Re: [PATCH 1/3] mtd: nand: raw: brcmnand: Refactored code and introduced inline functions

2019-06-01 Thread Boris Brezillon
On Thu, 30 May 2019 17:20:35 -0400 Kamal Dasu wrote: > Refactored NAND ECC and CMD address configuration code to use inline > functions. I'd expect the compiler to be smart enough to decide when inlining is appropriate. Did you check that adding the inline specifier actually makes a difference?

[PATCH 1/3] mtd: nand: raw: brcmnand: Refactored code and introduced inline functions

2019-05-30 Thread Kamal Dasu
Refactored NAND ECC and CMD address configuration code to use inline functions. Signed-off-by: Kamal Dasu --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 100 +++ 1 file changed, 62 insertions(+), 38 deletions(-) diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c