Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-26 Thread Grant Grundler
On Tue, Jul 26, 2016 at 2:14 PM, Robert Foss wrote: ... > Thanks for the feedback (for this patch and the other ones)! > I'm preparing a v2 and will submit it withing a day or two. Excellent! very welcome and thanks again for picking this up. ... >> FTR, current

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-26 Thread Grant Grundler
On Tue, Jul 26, 2016 at 2:14 PM, Robert Foss wrote: ... > Thanks for the feedback (for this patch and the other ones)! > I'm preparing a v2 and will submit it withing a day or two. Excellent! very welcome and thanks again for picking this up. ... >> FTR, current drivers/net/usb/ax88179_178a.c

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-26 Thread Robert Foss
From: Grant Grundler For the record, I believe I am not the author of these patches. I believe the original author is Signed-off-by: Freddy Xin as recorded in the following code reviews (and testing) that I was responsible for:

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-26 Thread Robert Foss
From: Grant Grundler For the record, I believe I am not the author of these patches. I believe the original author is Signed-off-by: Freddy Xin as recorded in the following code reviews (and testing) that I was responsible for:

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-25 Thread David Miller
Please correct the problems Grant Grundler mentioned in all of these patches, and resubmit this entire series freshly. Also, please include a proper "[PATCH 0/3] ..." introduction posting for the series which explains what this series is about, how it implements what it is doing, and why it is

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-25 Thread David Miller
Please correct the problems Grant Grundler mentioned in all of these patches, and resubmit this entire series freshly. Also, please include a proper "[PATCH 0/3] ..." introduction posting for the series which explains what this series is about, how it implements what it is doing, and why it is

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-25 Thread Grant Grundler
[as plain text this time...] Robert, On Mon, Jul 25, 2016 at 10:40 AM, wrote: > From: Grant Grundler For the record, I believe I am not the author of these patches. I believe the original author is Signed-off-by: Freddy Xin

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-25 Thread Grant Grundler
[as plain text this time...] Robert, On Mon, Jul 25, 2016 at 10:40 AM, wrote: > From: Grant Grundler For the record, I believe I am not the author of these patches. I believe the original author is Signed-off-by: Freddy Xin as recorded in the following code reviews (and testing) that

[PATCH 1/3] net: asix: Add in_pm parameter

2016-07-25 Thread robert . foss
From: Grant Grundler In order to R/W registers in suspend/resume functions, in_pm flags are added to some functions to determine whether the nopm version of usb functions is called. Save BMCR and ANAR PHY registers in suspend function and restore them in resume function.

[PATCH 1/3] net: asix: Add in_pm parameter

2016-07-25 Thread robert . foss
From: Grant Grundler In order to R/W registers in suspend/resume functions, in_pm flags are added to some functions to determine whether the nopm version of usb functions is called. Save BMCR and ANAR PHY registers in suspend function and restore them in resume function. Reset HW in resume