Re: [PATCH 1/3] perf tools: Put proper period for for samples without PERIOD sample_type

2014-02-05 Thread Namhyung Kim
Hi Jiri, On Wed, 5 Feb 2014 15:33:29 +0100, Jiri Olsa wrote: > On Wed, Feb 05, 2014 at 10:27:30AM +0900, Namhyung Kim wrote: >> Hi Jiri, >> >> On Mon, 3 Feb 2014 12:44:41 +0100, Jiri Olsa wrote: >> > We use PERF_SAMPLE_PERIOD sample type only for frequency >> > setup -F (default) option. The -c

Re: [PATCH 1/3] perf tools: Put proper period for for samples without PERIOD sample_type

2014-02-05 Thread Jiri Olsa
On Wed, Feb 05, 2014 at 10:27:30AM +0900, Namhyung Kim wrote: > Hi Jiri, > > On Mon, 3 Feb 2014 12:44:41 +0100, Jiri Olsa wrote: > > We use PERF_SAMPLE_PERIOD sample type only for frequency > > setup -F (default) option. The -c does not need store period, > > because it's always the same. > > > >

Re: [PATCH 1/3] perf tools: Put proper period for for samples without PERIOD sample_type

2014-02-04 Thread Namhyung Kim
Hi Jiri, On Mon, 3 Feb 2014 12:44:41 +0100, Jiri Olsa wrote: > We use PERF_SAMPLE_PERIOD sample type only for frequency > setup -F (default) option. The -c does not need store period, > because it's always the same. > > In -c case the report code uses '1' as period. Fixing > it to perf_event_att

[PATCH 1/3] perf tools: Put proper period for for samples without PERIOD sample_type

2014-02-03 Thread Jiri Olsa
We use PERF_SAMPLE_PERIOD sample type only for frequency setup -F (default) option. The -c does not need store period, because it's always the same. In -c case the report code uses '1' as period. Fixing it to perf_event_attr::sample_period. Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: David