Re: [PATCH 1/3] platform/chrome: wilco_ec: Standardize mailbox interface

2019-04-05 Thread Nick Crews
> > Now I'm confused, isn't this the same patch I picked this morning from > you and is already applied in chrome-platform for-next? > Sorry, I didn't see that it was already applied in for-next. Just ignore this patch and assume that the next two in this series are based off the current state of

Re: [PATCH 1/3] platform/chrome: wilco_ec: Standardize mailbox interface

2019-04-05 Thread Enric Balletbo Serra
Hi Nick, Missatge de Nick Crews del dia dv., 5 d’abr. 2019 a les 22:09: > > The current API for the wilco EC mailbox interface is bad. > > It assumes that most messages sent to the EC follow a similar structure, > with a command byte in MBOX[0], followed by a junk byte, followed by > actual

[PATCH 1/3] platform/chrome: wilco_ec: Standardize mailbox interface

2019-04-05 Thread Nick Crews
The current API for the wilco EC mailbox interface is bad. It assumes that most messages sent to the EC follow a similar structure, with a command byte in MBOX[0], followed by a junk byte, followed by actual data. This doesn't happen in several cases, such as setting the RTC time, using the raw