Re: [PATCH 1/3] power_supply: add few more values and props

2008-01-06 Thread Dmitry
Hi, 2008/1/7, Anton Vorontsov <[EMAIL PROTECTED]>: > On Mon, Jan 07, 2008 at 02:13:07AM +0300, Dmitry wrote: > > Hi, > > > > 2008/1/7, Anton Vorontsov <[EMAIL PROTECTED]>: > > > On Mon, Jan 07, 2008 at 01:15:32AM +0300, Dmitry wrote: > > > [...] > > > > > > + POWER_SUPPLY_ATTR(voltage_max), >

Re: [PATCH 1/3] power_supply: add few more values and props

2008-01-06 Thread Anton Vorontsov
On Mon, Jan 07, 2008 at 02:13:07AM +0300, Dmitry wrote: > Hi, > > 2008/1/7, Anton Vorontsov <[EMAIL PROTECTED]>: > > On Mon, Jan 07, 2008 at 01:15:32AM +0300, Dmitry wrote: > > [...] > > > > > + POWER_SUPPLY_ATTR(voltage_max), > > > > > + POWER_SUPPLY_ATTR(voltage_min), > > > > > > > >

Re: [PATCH 1/3] power_supply: add few more values and props

2008-01-06 Thread Dmitry
Hi, 2008/1/7, Anton Vorontsov <[EMAIL PROTECTED]>: > On Mon, Jan 07, 2008 at 01:15:32AM +0300, Dmitry wrote: > [...] > > > > + POWER_SUPPLY_ATTR(voltage_max), > > > > + POWER_SUPPLY_ATTR(voltage_min), > > > > > > I'd suggest keep Documentation/power_supply_class.txt in sync > > > wrt new

Re: [PATCH 1/3] power_supply: add few more values and props

2008-01-06 Thread Anton Vorontsov
On Mon, Jan 07, 2008 at 01:15:32AM +0300, Dmitry wrote: [...] > > > + POWER_SUPPLY_ATTR(voltage_max), > > > + POWER_SUPPLY_ATTR(voltage_min), > > > > I'd suggest keep Documentation/power_supply_class.txt in sync > > wrt new properties, to distinct their meanings and usage. > > > > I assume

Re: [PATCH 1/3] power_supply: add few more values and props

2008-01-06 Thread Dmitry
Hi, 2008/1/6, Anton Vorontsov <[EMAIL PROTECTED]>: > On Sun, Jan 06, 2008 at 03:27:18PM +0300, Dmitry Baryshkov wrote: > > Add LiMn (one of the most common for small non-rechargable batteries)i > > battery technology and voltage_min/_max properties support. > > > > Signed-off-by: Dmitry Baryshkov

Re: [PATCH 1/3] power_supply: add few more values and props

2008-01-06 Thread Anton Vorontsov
On Sun, Jan 06, 2008 at 03:27:18PM +0300, Dmitry Baryshkov wrote: > Add LiMn (one of the most common for small non-rechargable batteries)i > battery technology and voltage_min/_max properties support. > > Signed-off-by: Dmitry Baryshkov <[EMAIL PROTECTED]> Much thanks, all patches look good to

[PATCH 1/3] power_supply: add few more values and props

2008-01-06 Thread Dmitry Baryshkov
Add LiMn (one of the most common for small non-rechargable batteries)i battery technology and voltage_min/_max properties support. Signed-off-by: Dmitry Baryshkov <[EMAIL PROTECTED]> diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c index 249f61b..45d2f95

Re: [PATCH 1/3] power_supply: add few more values and props

2008-01-06 Thread Anton Vorontsov
On Mon, Jan 07, 2008 at 01:15:32AM +0300, Dmitry wrote: [...] + POWER_SUPPLY_ATTR(voltage_max), + POWER_SUPPLY_ATTR(voltage_min), I'd suggest keep Documentation/power_supply_class.txt in sync wrt new properties, to distinct their meanings and usage. I assume you're using

Re: [PATCH 1/3] power_supply: add few more values and props

2008-01-06 Thread Dmitry
Hi, 2008/1/7, Anton Vorontsov [EMAIL PROTECTED]: On Mon, Jan 07, 2008 at 01:15:32AM +0300, Dmitry wrote: [...] + POWER_SUPPLY_ATTR(voltage_max), + POWER_SUPPLY_ATTR(voltage_min), I'd suggest keep Documentation/power_supply_class.txt in sync wrt new properties, to

Re: [PATCH 1/3] power_supply: add few more values and props

2008-01-06 Thread Anton Vorontsov
On Mon, Jan 07, 2008 at 02:13:07AM +0300, Dmitry wrote: Hi, 2008/1/7, Anton Vorontsov [EMAIL PROTECTED]: On Mon, Jan 07, 2008 at 01:15:32AM +0300, Dmitry wrote: [...] + POWER_SUPPLY_ATTR(voltage_max), + POWER_SUPPLY_ATTR(voltage_min), I'd suggest keep

Re: [PATCH 1/3] power_supply: add few more values and props

2008-01-06 Thread Dmitry
Hi, 2008/1/7, Anton Vorontsov [EMAIL PROTECTED]: On Mon, Jan 07, 2008 at 02:13:07AM +0300, Dmitry wrote: Hi, 2008/1/7, Anton Vorontsov [EMAIL PROTECTED]: On Mon, Jan 07, 2008 at 01:15:32AM +0300, Dmitry wrote: [...] + POWER_SUPPLY_ATTR(voltage_max), +

[PATCH 1/3] power_supply: add few more values and props

2008-01-06 Thread Dmitry Baryshkov
Add LiMn (one of the most common for small non-rechargable batteries)i battery technology and voltage_min/_max properties support. Signed-off-by: Dmitry Baryshkov [EMAIL PROTECTED] diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c index 249f61b..45d2f95

Re: [PATCH 1/3] power_supply: add few more values and props

2008-01-06 Thread Anton Vorontsov
On Sun, Jan 06, 2008 at 03:27:18PM +0300, Dmitry Baryshkov wrote: Add LiMn (one of the most common for small non-rechargable batteries)i battery technology and voltage_min/_max properties support. Signed-off-by: Dmitry Baryshkov [EMAIL PROTECTED] Much thanks, all patches look good to me. Few