Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

On Sunday 06 November 2016 01:01 AM, Anton Blanchard wrote: > Hi, > >> kprobe, uprobe, hw-breakpoint and xmon are the only user of >> emulate_step. >> >> Kprobe / uprobe single-steps instruction if they can't emulate it, so >> there is no problem with them. As I mention, hw-breakpoint is broken.

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

On Sunday 06 November 2016 01:01 AM, Anton Blanchard wrote: > Hi, > >> kprobe, uprobe, hw-breakpoint and xmon are the only user of >> emulate_step. >> >> Kprobe / uprobe single-steps instruction if they can't emulate it, so >> there is no problem with them. As I mention, hw-breakpoint is broken.

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

Hi, > kprobe, uprobe, hw-breakpoint and xmon are the only user of > emulate_step. > > Kprobe / uprobe single-steps instruction if they can't emulate it, so > there is no problem with them. As I mention, hw-breakpoint is broken. > However I'm not sure about xmon, I need to check that. I was

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

Hi, > kprobe, uprobe, hw-breakpoint and xmon are the only user of > emulate_step. > > Kprobe / uprobe single-steps instruction if they can't emulate it, so > there is no problem with them. As I mention, hw-breakpoint is broken. > However I'm not sure about xmon, I need to check that. I was

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

On Friday 04 November 2016 07:37 AM, Andrew Donnellan wrote: > On 03/11/16 21:27, Ravi Bangoria wrote: >> Yes, kernel-space hw-breakpoint feature is broken on LE without this. > > Is there any actual user-visible feature that depends on this, or is this > solely for debugging and development

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

On Friday 04 November 2016 07:37 AM, Andrew Donnellan wrote: > On 03/11/16 21:27, Ravi Bangoria wrote: >> Yes, kernel-space hw-breakpoint feature is broken on LE without this. > > Is there any actual user-visible feature that depends on this, or is this > solely for debugging and development

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

On 03/11/16 21:27, Ravi Bangoria wrote: Yes, kernel-space hw-breakpoint feature is broken on LE without this. Is there any actual user-visible feature that depends on this, or is this solely for debugging and development purposes? It would of course be *nice* to have it in stable trees

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

On 03/11/16 21:27, Ravi Bangoria wrote: Yes, kernel-space hw-breakpoint feature is broken on LE without this. Is there any actual user-visible feature that depends on this, or is this solely for debugging and development purposes? It would of course be *nice* to have it in stable trees

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

On Thursday 03 November 2016 03:18 PM, Michael Ellerman wrote: > Ravi Bangoria writes: > >> On Thursday 03 November 2016 02:34 AM, Anton Blanchard wrote: >>> Hi Ravi, >>> emulate_step() uses a number of underlying kernel functions that were initially

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

On Thursday 03 November 2016 03:18 PM, Michael Ellerman wrote: > Ravi Bangoria writes: > >> On Thursday 03 November 2016 02:34 AM, Anton Blanchard wrote: >>> Hi Ravi, >>> emulate_step() uses a number of underlying kernel functions that were initially not enabled for LE. This has been

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

Ravi Bangoria writes: > On Thursday 03 November 2016 02:34 AM, Anton Blanchard wrote: >> Hi Ravi, >> >>> emulate_step() uses a number of underlying kernel functions that were >>> initially not enabled for LE. This has been rectified since. So, fix >>>

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

Ravi Bangoria writes: > On Thursday 03 November 2016 02:34 AM, Anton Blanchard wrote: >> Hi Ravi, >> >>> emulate_step() uses a number of underlying kernel functions that were >>> initially not enabled for LE. This has been rectified since. So, fix >>> emulate_step() for LE for the corresponding

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

On Thursday 03 November 2016 02:34 AM, Anton Blanchard wrote: > Hi Ravi, > >> emulate_step() uses a number of underlying kernel functions that were >> initially not enabled for LE. This has been rectified since. So, fix >> emulate_step() for LE for the corresponding instructions. > Thanks.

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

On Thursday 03 November 2016 02:34 AM, Anton Blanchard wrote: > Hi Ravi, > >> emulate_step() uses a number of underlying kernel functions that were >> initially not enabled for LE. This has been rectified since. So, fix >> emulate_step() for LE for the corresponding instructions. > Thanks.

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

Hi Ravi, > emulate_step() uses a number of underlying kernel functions that were > initially not enabled for LE. This has been rectified since. So, fix > emulate_step() for LE for the corresponding instructions. Thanks. Should this be queued up for stable? Anton > Reported-by: Anton Blanchard

Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

Hi Ravi, > emulate_step() uses a number of underlying kernel functions that were > initially not enabled for LE. This has been rectified since. So, fix > emulate_step() for LE for the corresponding instructions. Thanks. Should this be queued up for stable? Anton > Reported-by: Anton Blanchard

[PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

emulate_step() uses a number of underlying kernel functions that were initially not enabled for LE. This has been rectified since. So, fix emulate_step() for LE for the corresponding instructions. Reported-by: Anton Blanchard Signed-off-by: Ravi Bangoria

[PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

emulate_step() uses a number of underlying kernel functions that were initially not enabled for LE. This has been rectified since. So, fix emulate_step() for LE for the corresponding instructions. Reported-by: Anton Blanchard Signed-off-by: Ravi Bangoria --- arch/powerpc/lib/sstep.c | 20