Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot()

2016-08-10 Thread Konstantin Khlebnikov
On Tue, Aug 9, 2016 at 6:27 PM, Ross Zwisler wrote: > On Mon, Aug 08, 2016 at 10:21:39PM +0300, Konstantin Khlebnikov wrote: > <> >> NAK. This is fast path and it's already bloated. >> I want to revert most changes here and rework "multiorder" entries. >> >> Here you

Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot()

2016-08-10 Thread Konstantin Khlebnikov
On Tue, Aug 9, 2016 at 6:27 PM, Ross Zwisler wrote: > On Mon, Aug 08, 2016 at 10:21:39PM +0300, Konstantin Khlebnikov wrote: > <> >> NAK. This is fast path and it's already bloated. >> I want to revert most changes here and rework "multiorder" entries. >> >> Here you can find almost ready

Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot()

2016-08-10 Thread Ross Zwisler
On Wed, Aug 10, 2016 at 09:29:23AM +0300, Konstantin Khlebnikov wrote: > On Tue, Aug 9, 2016 at 6:27 PM, Ross Zwisler > wrote: > > On Mon, Aug 08, 2016 at 10:21:39PM +0300, Konstantin Khlebnikov wrote: > > <> > >> NAK. This is fast path and it's already bloated. > >>

Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot()

2016-08-10 Thread Ross Zwisler
On Wed, Aug 10, 2016 at 09:29:23AM +0300, Konstantin Khlebnikov wrote: > On Tue, Aug 9, 2016 at 6:27 PM, Ross Zwisler > wrote: > > On Mon, Aug 08, 2016 at 10:21:39PM +0300, Konstantin Khlebnikov wrote: > > <> > >> NAK. This is fast path and it's already bloated. > >> I want to revert most changes

Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot()

2016-08-09 Thread Ross Zwisler
On Mon, Aug 08, 2016 at 10:21:39PM +0300, Konstantin Khlebnikov wrote: <> > NAK. This is fast path and it's already bloated. > I want to revert most changes here and rework "multiorder" entries. > > Here you can find almost ready patchset for that >

Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot()

2016-08-09 Thread Ross Zwisler
On Mon, Aug 08, 2016 at 10:21:39PM +0300, Konstantin Khlebnikov wrote: <> > NAK. This is fast path and it's already bloated. > I want to revert most changes here and rework "multiorder" entries. > > Here you can find almost ready patchset for that >

Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot()

2016-08-08 Thread Konstantin Khlebnikov
On Mon, Aug 8, 2016 at 9:57 PM, Ross Zwisler wrote: > There are four cases I can see where we could end up with a NULL 'slot' in > radix_tree_next_slot(). Yet radix_tree_next_slot() never actually checks > whether 'slot' is NULL. It just happens that for the cases

Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot()

2016-08-08 Thread Konstantin Khlebnikov
On Mon, Aug 8, 2016 at 9:57 PM, Ross Zwisler wrote: > There are four cases I can see where we could end up with a NULL 'slot' in > radix_tree_next_slot(). Yet radix_tree_next_slot() never actually checks > whether 'slot' is NULL. It just happens that for the cases where 'slot' is > NULL, some

[PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot()

2016-08-08 Thread Ross Zwisler
There are four cases I can see where we could end up with a NULL 'slot' in radix_tree_next_slot(). Yet radix_tree_next_slot() never actually checks whether 'slot' is NULL. It just happens that for the cases where 'slot' is NULL, some other combination of factors prevents us from dereferencing

[PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot()

2016-08-08 Thread Ross Zwisler
There are four cases I can see where we could end up with a NULL 'slot' in radix_tree_next_slot(). Yet radix_tree_next_slot() never actually checks whether 'slot' is NULL. It just happens that for the cases where 'slot' is NULL, some other combination of factors prevents us from dereferencing