Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-04-14 Thread Paul E. McKenney
> >> > IMHO, I would prefer saving some useless instructions for better > >> > performance rather than giving too much flexibility on the API (also > >> > pretty sure the cast can be still done). > >> > >> OK, what I am going to do is to apply your patches f

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-04-14 Thread Paul E. McKenney
/paulmck/linux-rcu.git? Thanx, Paul From 8ac818d418068105623e43bbd289d9553c182e6c Mon Sep 17 00:00:00 2001 From: Patrick Marlier patrick.marl...@gmail.com Date: Tue, 24 Mar 2015 11:16:55 +0100 Subject: [PATCH 1/3] rculist: Fix

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-04-13 Thread Patrick Marlier
> > IMHO, I would prefer saving some useless instructions for better >> > performance rather than giving too much flexibility on the API (also >> > pretty sure the cast can be still done). >> >> OK, what I am going to do is to apply your patches for testing p

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-04-13 Thread Patrick Marlier
From 8ac818d418068105623e43bbd289d9553c182e6c Mon Sep 17 00:00:00 2001 From: Patrick Marlier patrick.marl...@gmail.com Date: Tue, 24 Mar 2015 11:16:55 +0100 Subject: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw Change to read effectively ptr with rcu_dereference_raw

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-28 Thread Paul E. McKenney
On Sat, Mar 28, 2015 at 03:42:10AM -0700, Paul E. McKenney wrote: > On Wed, Mar 25, 2015 at 04:01:24PM +0100, Patrick Marlier wrote: > > On 03/25/2015 03:30 PM, Paul E. McKenney wrote: > > >On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: > > >>Change to read effectively ptr with

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-28 Thread Paul E. McKenney
On Wed, Mar 25, 2015 at 04:01:24PM +0100, Patrick Marlier wrote: > On 03/25/2015 03:30 PM, Paul E. McKenney wrote: > >On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: > >>Change to read effectively ptr with rcu_dereference_raw and not the > >>__ptr variable on the stack. > >> >

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-28 Thread Paul E. McKenney
On Wed, Mar 25, 2015 at 04:01:24PM +0100, Patrick Marlier wrote: On 03/25/2015 03:30 PM, Paul E. McKenney wrote: On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by:

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-28 Thread Paul E. McKenney
On Sat, Mar 28, 2015 at 03:42:10AM -0700, Paul E. McKenney wrote: On Wed, Mar 25, 2015 at 04:01:24PM +0100, Patrick Marlier wrote: On 03/25/2015 03:30 PM, Paul E. McKenney wrote: On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: Change to read effectively ptr with

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-25 Thread Patrick Marlier
On 03/25/2015 03:30 PM, Paul E. McKenney wrote: On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by: Patrick Marlier Avoiding an extra load could be worthwhile in a

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-25 Thread Paul E. McKenney
On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: > Change to read effectively ptr with rcu_dereference_raw and not the > __ptr variable on the stack. > > Signed-off-by: Patrick Marlier Avoiding an extra load could be worthwhile in a number of situations, agreed. However, won't

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-25 Thread Paul E. McKenney
On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by: Patrick Marlier patrick.marl...@gmail.com Avoiding an extra load could be worthwhile in a number of situations,

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-25 Thread Patrick Marlier
On 03/25/2015 03:30 PM, Paul E. McKenney wrote: On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by: Patrick Marlier patrick.marl...@gmail.com Avoiding an extra load

[PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-24 Thread Patrick Marlier
Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by: Patrick Marlier --- include/linux/rculist.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/linux/rculist.h b/include/linux/rculist.h index

[PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-24 Thread Patrick Marlier
Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by: Patrick Marlier patrick.marl...@gmail.com --- include/linux/rculist.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/linux/rculist.h