Re: [PATCH 1/3] regcache: flat: Use cache element type in sizeof

2018-01-08 Thread Andrew F. Davis
On 01/08/2018 05:59 AM, Mark Brown wrote: > On Sun, Jan 07, 2018 at 05:22:32PM -0600, Andrew F. Davis wrote: >> A single cache element may not always be unsigned int, use a >> cache element in sizeof over hard-coding its type. > > A cache element is *always* unsigned int. What you mean to say

Re: [PATCH 1/3] regcache: flat: Use cache element type in sizeof

2018-01-08 Thread Andrew F. Davis
On 01/08/2018 05:59 AM, Mark Brown wrote: > On Sun, Jan 07, 2018 at 05:22:32PM -0600, Andrew F. Davis wrote: >> A single cache element may not always be unsigned int, use a >> cache element in sizeof over hard-coding its type. > > A cache element is *always* unsigned int. What you mean to say

Re: [PATCH 1/3] regcache: flat: Use cache element type in sizeof

2018-01-08 Thread Mark Brown
On Sun, Jan 07, 2018 at 05:22:32PM -0600, Andrew F. Davis wrote: > A single cache element may not always be unsigned int, use a > cache element in sizeof over hard-coding its type. A cache element is *always* unsigned int. What you mean to say here is that this helps if in future someone changes

Re: [PATCH 1/3] regcache: flat: Use cache element type in sizeof

2018-01-08 Thread Mark Brown
On Sun, Jan 07, 2018 at 05:22:32PM -0600, Andrew F. Davis wrote: > A single cache element may not always be unsigned int, use a > cache element in sizeof over hard-coding its type. A cache element is *always* unsigned int. What you mean to say here is that this helps if in future someone changes

[PATCH 1/3] regcache: flat: Use cache element type in sizeof

2018-01-07 Thread Andrew F. Davis
A single cache element may not always be unsigned int, use a cache element in sizeof over hard-coding its type. Signed-off-by: Andrew F. Davis --- drivers/base/regmap/regcache-flat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/3] regcache: flat: Use cache element type in sizeof

2018-01-07 Thread Andrew F. Davis
A single cache element may not always be unsigned int, use a cache element in sizeof over hard-coding its type. Signed-off-by: Andrew F. Davis --- drivers/base/regmap/regcache-flat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regcache-flat.c