Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-19 Thread Alan Cox
> > > > > + if (!port->iso7816_config) > > > + return -ENOIOCTLCMD; > > > > Why this error value? > > > > It was a mimic of RS485. Which is what you want - it means the upper tty layer knows to offer the ioctl to other places and then return appropriately. Alan

Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-13 Thread Greg KH
On Fri, Jul 13, 2018 at 09:56:48AM +0200, Ludovic Desroches wrote: > On Thu, Jul 12, 2018 at 05:02:29PM +0200, Greg KH wrote: > > On Wed, Jul 11, 2018 at 03:16:36PM +0200, Ludovic Desroches wrote: > > > From: Nicolas Ferre > > > > > > Add the ISO7816 ioctl and associated accessors and data struct

Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-13 Thread Ludovic Desroches
On Thu, Jul 12, 2018 at 04:58:08PM +0200, Greg KH wrote: > On Wed, Jul 11, 2018 at 03:16:36PM +0200, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > Add the ISO7816 ioctl and associated accessors and data structure. > > Drivers can then use this common implementation to handle ISO7816. >

Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-13 Thread Ludovic Desroches
On Thu, Jul 12, 2018 at 05:02:29PM +0200, Greg KH wrote: > On Wed, Jul 11, 2018 at 03:16:36PM +0200, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > Add the ISO7816 ioctl and associated accessors and data structure. > > Drivers can then use this common implementation to handle ISO7816. >

Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-12 Thread Greg KH
On Wed, Jul 11, 2018 at 03:16:36PM +0200, Ludovic Desroches wrote: > From: Nicolas Ferre > > Add the ISO7816 ioctl and associated accessors and data structure. > Drivers can then use this common implementation to handle ISO7816. > > Signed-off-by: Nicolas Ferre > [ludovic.desroc...@microchip.co

Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-12 Thread Greg KH
On Wed, Jul 11, 2018 at 03:16:36PM +0200, Ludovic Desroches wrote: > From: Nicolas Ferre > > Add the ISO7816 ioctl and associated accessors and data structure. > Drivers can then use this common implementation to handle ISO7816. > > Signed-off-by: Nicolas Ferre > [ludovic.desroc...@microchip.co

Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-11 Thread kbuild test robot
Hi Nicolas, I love your patch! Yet something to improve: [auto build test ERROR on tty/tty-testing] [also build test ERROR on v4.18-rc4 next-20180711] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/com

Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-11 Thread kbuild test robot
Hi Nicolas, I love your patch! Yet something to improve: [auto build test ERROR on tty/tty-testing] [also build test ERROR on v4.18-rc4 next-20180711] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/com

[PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-11 Thread Ludovic Desroches
From: Nicolas Ferre Add the ISO7816 ioctl and associated accessors and data structure. Drivers can then use this common implementation to handle ISO7816. Signed-off-by: Nicolas Ferre [ludovic.desroc...@microchip.com: squash and rebase, removal of gpios, checkpatch fixes] Signed-off-by: Ludovic