Re: [PATCH 1/3] watchdog: bcm2835_wdt: constify _ops and _info structures

2016-07-17 Thread Wim Van Sebroeck
Hi Rasmus, > These are never modified, so might as well be const. > > Signed-off-by: Rasmus Villemoes > --- > drivers/watchdog/bcm2835_wdt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/bcm2835_wdt.c

Re: [PATCH 1/3] watchdog: bcm2835_wdt: constify _ops and _info structures

2016-07-17 Thread Wim Van Sebroeck
Hi Rasmus, > These are never modified, so might as well be const. > > Signed-off-by: Rasmus Villemoes > --- > drivers/watchdog/bcm2835_wdt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c > index

Re: [PATCH 1/3] watchdog: bcm2835_wdt: constify _ops and _info structures

2016-07-15 Thread Guenter Roeck
On 07/15/2016 01:15 AM, Rasmus Villemoes wrote: These are never modified, so might as well be const. Signed-off-by: Rasmus Villemoes Reviewed-by: Guenter Roeck --- drivers/watchdog/bcm2835_wdt.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [PATCH 1/3] watchdog: bcm2835_wdt: constify _ops and _info structures

2016-07-15 Thread Guenter Roeck
On 07/15/2016 01:15 AM, Rasmus Villemoes wrote: These are never modified, so might as well be const. Signed-off-by: Rasmus Villemoes Reviewed-by: Guenter Roeck --- drivers/watchdog/bcm2835_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 1/3] watchdog: bcm2835_wdt: constify _ops and _info structures

2016-07-15 Thread Rasmus Villemoes
These are never modified, so might as well be const. Signed-off-by: Rasmus Villemoes --- drivers/watchdog/bcm2835_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c index

[PATCH 1/3] watchdog: bcm2835_wdt: constify _ops and _info structures

2016-07-15 Thread Rasmus Villemoes
These are never modified, so might as well be const. Signed-off-by: Rasmus Villemoes --- drivers/watchdog/bcm2835_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c index 2e6164c..733e402 100644 ---