Re: [PATCH 1/3] watchdog: cadence: Simplify with dev_err_probe()

2020-10-02 Thread Guenter Roeck
On Fri, Oct 02, 2020 at 06:31:24PM +0200, Krzysztof Kozlowski wrote: > On Tue, Sep 01, 2020 at 08:49:52AM -0700, Guenter Roeck wrote: > > On Tue, Sep 01, 2020 at 05:31:39PM +0200, Krzysztof Kozlowski wrote: > > > Common pattern of handling deferred probe can be simplified with > > > dev_err_probe()

Re: [PATCH 1/3] watchdog: cadence: Simplify with dev_err_probe()

2020-10-02 Thread Krzysztof Kozlowski
On Tue, Sep 01, 2020 at 08:49:52AM -0700, Guenter Roeck wrote: > On Tue, Sep 01, 2020 at 05:31:39PM +0200, Krzysztof Kozlowski wrote: > > Common pattern of handling deferred probe can be simplified with > > dev_err_probe(). Less code and the error value gets printed. > > > > Signed-off-by: Krzysz

Re: [PATCH 1/3] watchdog: cadence: Simplify with dev_err_probe()

2020-09-01 Thread Guenter Roeck
On Tue, Sep 01, 2020 at 05:31:39PM +0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Hmm, I had replied to this but I don't see it on patchwor

[PATCH 1/3] watchdog: cadence: Simplify with dev_err_probe()

2020-09-01 Thread Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski --- drivers/watchdog/cadence_wdt.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/watchdog/caden

Re: [PATCH 1/3] watchdog: cadence: Simplify with dev_err_probe()

2020-09-01 Thread Guenter Roeck
On Tue, Sep 01, 2020 at 05:31:39PM +0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Guenter Roeck > --- > drivers/watchdog/ca