Re: [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-25 Thread Scott Wood
On Thu, 2014-09-25 at 11:44 -0500, German Rivera wrote: > On 09/25/2014 11:16 AM, Scott Wood wrote: > > Then again, the management complex is not supposed to be on the > > performance critical path, so why not simplify by just always do the > > locking here? > > > But about the few MC commands

Re: [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-25 Thread German Rivera
On 09/25/2014 11:16 AM, Scott Wood wrote: On Thu, 2014-09-25 at 10:44 -0500, German Rivera wrote: On 09/24/2014 10:40 PM, Kim Phillips wrote: On Wed, 24 Sep 2014 21:23:59 -0500 German Rivera wrote: On 09/23/2014 07:49 PM, Kim Phillips wrote: On Fri, 19 Sep 2014 17:49:39 -0500 "J. German

Re: [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-25 Thread Scott Wood
On Thu, 2014-09-25 at 10:44 -0500, German Rivera wrote: > > On 09/24/2014 10:40 PM, Kim Phillips wrote: > > On Wed, 24 Sep 2014 21:23:59 -0500 > > German Rivera wrote: > > > >> On 09/23/2014 07:49 PM, Kim Phillips wrote: > >>> On Fri, 19 Sep 2014 17:49:39 -0500 > >>> "J. German Rivera" wrote: >

Re: [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-25 Thread German Rivera
On 09/24/2014 10:40 PM, Kim Phillips wrote: On Wed, 24 Sep 2014 21:23:59 -0500 German Rivera wrote: On 09/23/2014 07:49 PM, Kim Phillips wrote: On Fri, 19 Sep 2014 17:49:39 -0500 "J. German Rivera" wrote: + * Delay in microseconds between polling iterations while + * waiting for MC

Re: [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-25 Thread German Rivera
On 09/24/2014 10:40 PM, Kim Phillips wrote: On Wed, 24 Sep 2014 21:23:59 -0500 German Rivera german.riv...@freescale.com wrote: On 09/23/2014 07:49 PM, Kim Phillips wrote: On Fri, 19 Sep 2014 17:49:39 -0500 J. German Rivera german.riv...@freescale.com wrote: + * Delay in microseconds

Re: [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-25 Thread Scott Wood
On Thu, 2014-09-25 at 10:44 -0500, German Rivera wrote: On 09/24/2014 10:40 PM, Kim Phillips wrote: On Wed, 24 Sep 2014 21:23:59 -0500 German Rivera german.riv...@freescale.com wrote: On 09/23/2014 07:49 PM, Kim Phillips wrote: On Fri, 19 Sep 2014 17:49:39 -0500 J. German Rivera

Re: [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-25 Thread German Rivera
On 09/25/2014 11:16 AM, Scott Wood wrote: On Thu, 2014-09-25 at 10:44 -0500, German Rivera wrote: On 09/24/2014 10:40 PM, Kim Phillips wrote: On Wed, 24 Sep 2014 21:23:59 -0500 German Rivera german.riv...@freescale.com wrote: On 09/23/2014 07:49 PM, Kim Phillips wrote: On Fri, 19 Sep 2014

Re: [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-25 Thread Scott Wood
On Thu, 2014-09-25 at 11:44 -0500, German Rivera wrote: On 09/25/2014 11:16 AM, Scott Wood wrote: Then again, the management complex is not supposed to be on the performance critical path, so why not simplify by just always do the locking here? But about the few MC commands that need to

Re: [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-24 Thread Kim Phillips
On Wed, 24 Sep 2014 21:23:59 -0500 German Rivera wrote: > On 09/23/2014 07:49 PM, Kim Phillips wrote: > > On Fri, 19 Sep 2014 17:49:39 -0500 > > "J. German Rivera" wrote: > > > >> + * Delay in microseconds between polling iterations while > >> + * waiting for MC command completion > >> + */ >

Re: [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-24 Thread German Rivera
On 09/23/2014 07:49 PM, Kim Phillips wrote: On Fri, 19 Sep 2014 17:49:39 -0500 "J. German Rivera" wrote: +int mc_get_version(struct fsl_mc_io *mc_io, struct mc_version *mc_ver_info) ... + err = mc_send_command(mc_io, ); + if (err) + return err; + +

Re: [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-24 Thread German Rivera
On 09/23/2014 07:49 PM, Kim Phillips wrote: On Fri, 19 Sep 2014 17:49:39 -0500 J. German Rivera german.riv...@freescale.com wrote: +int mc_get_version(struct fsl_mc_io *mc_io, struct mc_version *mc_ver_info) ... + err = mc_send_command(mc_io, cmd); + if (err) +

Re: [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-24 Thread Kim Phillips
On Wed, 24 Sep 2014 21:23:59 -0500 German Rivera german.riv...@freescale.com wrote: On 09/23/2014 07:49 PM, Kim Phillips wrote: On Fri, 19 Sep 2014 17:49:39 -0500 J. German Rivera german.riv...@freescale.com wrote: + * Delay in microseconds between polling iterations while + * waiting

Re: [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-23 Thread Kim Phillips
On Fri, 19 Sep 2014 17:49:39 -0500 "J. German Rivera" wrote: > +int mc_get_version(struct fsl_mc_io *mc_io, struct mc_version *mc_ver_info) ... > + err = mc_send_command(mc_io, ); > + if (err) > + return err; > + > + DPMNG_RSP_GET_VERSION(cmd, mc_ver_info);

Re: [PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-23 Thread Kim Phillips
On Fri, 19 Sep 2014 17:49:39 -0500 J. German Rivera german.riv...@freescale.com wrote: +int mc_get_version(struct fsl_mc_io *mc_io, struct mc_version *mc_ver_info) ... + err = mc_send_command(mc_io, cmd); + if (err) + return err; + +

[PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-19 Thread J. German Rivera
From: "J. German Rivera" APIs to access the Management Complex (MC) hardware module of Freescale LS2 SoCs. This patch includes APIs to check the MC firmware version and to manipulate DPRC objects in the MC. Signed-off-by: J. German Rivera Signed-off-by: Stuart Yoder --- Changes in v2: -

[PATCH 1/3 v2] drivers/bus: Added Freescale Management Complex APIs

2014-09-19 Thread J. German Rivera
From: J. German Rivera german.riv...@freescale.com APIs to access the Management Complex (MC) hardware module of Freescale LS2 SoCs. This patch includes APIs to check the MC firmware version and to manipulate DPRC objects in the MC. Signed-off-by: J. German Rivera german.riv...@freescale.com