Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-26 Thread Mark Brown
On Fri, Feb 26, 2016 at 10:04:15PM +0100, Robert Jarzmik wrote: > Ok, let me think about it and propose something, an approach. > I must admit I like the structure I saw in drivers/amba/bus.c, ie. to have > something like : ... > Well, if I'm totally mistaken, tell me. If not it will take me a

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-26 Thread Robert Jarzmik
Mark Brown writes: > On Fri, Feb 26, 2016 at 02:33:49AM +0100, Robert Jarzmik wrote: >> Mark Brown writes: > >> > It will not be called, the generic AC'97 code will be used. > >> Ok, if it's not called no code in sound/soc/codecs/wm9713.c will be used, >> right >> ? >> In that case wm9713_set_d

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-25 Thread Mark Brown
On Fri, Feb 26, 2016 at 02:33:49AM +0100, Robert Jarzmik wrote: > Mark Brown writes: > > It will not be called, the generic AC'97 code will be used. > Ok, if it's not called no code in sound/soc/codecs/wm9713.c will be used, > right > ? > In that case wm9713_set_dai_clkdiv() will never be used,

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-25 Thread Robert Jarzmik
Mark Brown writes: >> > It will eumerate the AC'97 bus by itself and does not need the CODEC to >> > be described. > >> I think I still don't get it. > >> So let's rephrase it another way : how will the function wm9713_probe() be >> called, ie. what is the possible function backtrace leading to t

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-20 Thread Mark Brown
On Sat, Feb 20, 2016 at 11:24:02PM +0100, Robert Jarzmik wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > Mark Brown writes: > > On Sat, Feb 20, 2016 at 09:32:58P

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-20 Thread Robert Jarzmik
Mark Brown writes: > On Sat, Feb 20, 2016 at 09:32:58PM +0100, Robert Jarzmik wrote: >> Mark Brown writes: >> > On Sat, Feb 20, 2016 at 07:22:04PM +0100, Robert Jarzmik wrote: >> I will. By now I fail to see how this will help in the wm9713 probing and >> detection ... > > It will eumerate the A

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-20 Thread Mark Brown
On Sat, Feb 20, 2016 at 09:32:58PM +0100, Robert Jarzmik wrote: > Mark Brown writes: > > On Sat, Feb 20, 2016 at 07:22:04PM +0100, Robert Jarzmik wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-20 Thread Robert Jarzmik
Mark Brown writes: > On Sat, Feb 20, 2016 at 07:22:04PM +0100, Robert Jarzmik wrote: >> Mark Brown writes: Removed DT people from this conversation. >> > Instead we should be probing at runtime (as the non-ASoC AC'97 code does) >> > or >> > something similar. > >> When you say "non-ASoC AC'97

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-20 Thread Mark Brown
On Sat, Feb 20, 2016 at 07:22:04PM +0100, Robert Jarzmik wrote: > Mark Brown writes: > > Instead we should be probing at runtime (as the non-ASoC AC'97 code does) or > > something similar. > When you say "non-ASoC AC'97 code", which file are you referring to ? Is it > sound/pci/ac97/ac97_codec.c

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-20 Thread Robert Jarzmik
Mark Brown writes: > On Sat, Feb 20, 2016 at 03:37:56PM +0100, Robert Jarzmik wrote: > >> +WM9713 audio CODEC >> + >> +This devices supports I2C. > > No, it clearly doesn't... Right, it supports AC97. > The problem with doing this is that since AC'97 is an enumerable bus we really > shouldn't ne

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-20 Thread Mark Brown
On Sat, Feb 20, 2016 at 03:37:56PM +0100, Robert Jarzmik wrote: > +WM9713 audio CODEC > + > +This devices supports I2C. No, it clearly doesn't... The problem with doing this is that since AC'97 is an enumerable bus we really shouldn't need to list AC'97 CODECs in the device tree. Instead we sho

[PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2016-02-20 Thread Robert Jarzmik
This adds a binding for the Wolfson WM9713 audio codec. Signed-off-by: Robert Jarzmik --- Documentation/devicetree/bindings/sound/wm9713.txt | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/wm9713.txt diff --git a/Documentation/de