Re: [PATCH 1/4] efi: provide a generic efi_config_init()

2013-07-30 Thread Tony Luck
On Tue, Jul 30, 2013 at 11:02 AM, Leif Lindholm wrote: > So I guess the clean way to deal with that would be to make the > memremap definition a separate patch? Or just pull: +#define early_memremap(phys_addr, size)early_ioremap(phys_addr, size) out of part 3 and put it into part1 (along

Re: [PATCH 1/4] efi: provide a generic efi_config_init()

2013-07-30 Thread Leif Lindholm
On Tue, Jul 30, 2013 at 10:53:10AM -0700, Tony Luck wrote: > On Tue, Jul 30, 2013 at 9:47 AM, Leif Lindholm > wrote: > > + /* > > +* Let's see what config tables the firmware passed to us. > > +*/ > > + config_tables = early_mememap(efi.systab->tables, > > +

Re: [PATCH 1/4] efi: provide a generic efi_config_init()

2013-07-30 Thread Tony Luck
On Tue, Jul 30, 2013 at 9:47 AM, Leif Lindholm wrote: > + /* > +* Let's see what config tables the firmware passed to us. > +*/ > + config_tables = early_mememap(efi.systab->tables, > + efi.systab->nr_tables * sz); Breaks bisection

[PATCH 1/4] efi: provide a generic efi_config_init()

2013-07-30 Thread Leif Lindholm
Common to (U)EFI support on all platforms is the global "efi" data structure, and the code that parses the System Table to locate addresses to populate that structure with. This patch adds both of these to the global EFI driver code. Since existing code for both x86 and ia64 contained handling

[PATCH 1/4] efi: provide a generic efi_config_init()

2013-07-30 Thread Leif Lindholm
Common to (U)EFI support on all platforms is the global efi data structure, and the code that parses the System Table to locate addresses to populate that structure with. This patch adds both of these to the global EFI driver code. Since existing code for both x86 and ia64 contained handling of

Re: [PATCH 1/4] efi: provide a generic efi_config_init()

2013-07-30 Thread Tony Luck
On Tue, Jul 30, 2013 at 9:47 AM, Leif Lindholm leif.lindh...@linaro.org wrote: + /* +* Let's see what config tables the firmware passed to us. +*/ + config_tables = early_mememap(efi.systab-tables, + efi.systab-nr_tables * sz);

Re: [PATCH 1/4] efi: provide a generic efi_config_init()

2013-07-30 Thread Leif Lindholm
On Tue, Jul 30, 2013 at 10:53:10AM -0700, Tony Luck wrote: On Tue, Jul 30, 2013 at 9:47 AM, Leif Lindholm leif.lindh...@linaro.org wrote: + /* +* Let's see what config tables the firmware passed to us. +*/ + config_tables = early_mememap(efi.systab-tables,

Re: [PATCH 1/4] efi: provide a generic efi_config_init()

2013-07-30 Thread Tony Luck
On Tue, Jul 30, 2013 at 11:02 AM, Leif Lindholm leif.lindh...@linaro.org wrote: So I guess the clean way to deal with that would be to make the memremap definition a separate patch? Or just pull: +#define early_memremap(phys_addr, size)early_ioremap(phys_addr, size) out of part 3 and