Re: [PATCH 1/4] erofs: fix setting up pcluster for temporary pages

2020-11-03 Thread Chao Yu
On 2020/11/4 9:11, Gao Xiang wrote: On Wed, Nov 04, 2020 at 09:05:56AM +0800, Chao Yu wrote: On 2020/10/22 22:57, Gao Xiang wrote: From: Gao Xiang pcluster should be only set up for all managed pages instead of temporary pages. Since it currently uses page->mapping to identify, the impact is

Re: [PATCH 1/4] erofs: fix setting up pcluster for temporary pages

2020-11-03 Thread Gao Xiang
On Wed, Nov 04, 2020 at 09:05:56AM +0800, Chao Yu wrote: > On 2020/10/22 22:57, Gao Xiang wrote: > > From: Gao Xiang > > > > pcluster should be only set up for all managed pages instead of > > temporary pages. Since it currently uses page->mapping to identify, > > the impact is minor for now. >

Re: [PATCH 1/4] erofs: fix setting up pcluster for temporary pages

2020-11-03 Thread Chao Yu
On 2020/10/22 22:57, Gao Xiang wrote: From: Gao Xiang pcluster should be only set up for all managed pages instead of temporary pages. Since it currently uses page->mapping to identify, the impact is minor for now. Fixes: 5ddcee1f3a1c ("erofs: get rid of __stagingpage_alloc helper") Cc: #

Re: [PATCH 1/4] erofs: fix setting up pcluster for temporary pages

2020-10-30 Thread Gao Xiang
On Fri, Oct 30, 2020 at 03:32:55PM +0200, Vladimir Zapolskiy wrote: > Hi Gao Xiang, > > On 10/30/20 2:47 PM, Gao Xiang wrote: > > Hi Vladimir, > > > > On Fri, Oct 30, 2020 at 02:20:31PM +0200, Vladimir Zapolskiy wrote: > > > Hello Gao Xiang, > > > > > > On 10/22/20 5:57 PM, Gao Xiang via

Re: [PATCH 1/4] erofs: fix setting up pcluster for temporary pages

2020-10-30 Thread Vladimir Zapolskiy
Hi Gao Xiang, On 10/30/20 2:47 PM, Gao Xiang wrote: Hi Vladimir, On Fri, Oct 30, 2020 at 02:20:31PM +0200, Vladimir Zapolskiy wrote: Hello Gao Xiang, On 10/22/20 5:57 PM, Gao Xiang via Linux-erofs wrote: From: Gao Xiang pcluster should be only set up for all managed pages instead of

Re: [PATCH 1/4] erofs: fix setting up pcluster for temporary pages

2020-10-30 Thread Gao Xiang
Hi Vladimir, On Fri, Oct 30, 2020 at 02:20:31PM +0200, Vladimir Zapolskiy wrote: > Hello Gao Xiang, > > On 10/22/20 5:57 PM, Gao Xiang via Linux-erofs wrote: > > From: Gao Xiang > > > > pcluster should be only set up for all managed pages instead of > > temporary pages. Since it currently uses

Re: [PATCH 1/4] erofs: fix setting up pcluster for temporary pages

2020-10-30 Thread Vladimir Zapolskiy
Hello Gao Xiang, On 10/22/20 5:57 PM, Gao Xiang via Linux-erofs wrote: From: Gao Xiang pcluster should be only set up for all managed pages instead of temporary pages. Since it currently uses page->mapping to identify, the impact is minor for now. Fixes: 5ddcee1f3a1c ("erofs: get rid of

[PATCH 1/4] erofs: fix setting up pcluster for temporary pages

2020-10-22 Thread Gao Xiang
From: Gao Xiang pcluster should be only set up for all managed pages instead of temporary pages. Since it currently uses page->mapping to identify, the impact is minor for now. Fixes: 5ddcee1f3a1c ("erofs: get rid of __stagingpage_alloc helper") Cc: # 5.5+ Signed-off-by: Gao Xiang ---