Re: [PATCH 1/4] linux/export: Fix alignment for 64-bit ksymtab entries

2023-12-23 Thread Masahiro Yamada
On Sat, Dec 23, 2023 at 5:11 AM Luis Chamberlain wrote: > > On Fri, Dec 22, 2023 at 04:01:30PM +0900, Masahiro Yamada wrote: > > On Fri, Dec 22, 2023 at 3:08 PM Luis Chamberlain wrote: > > > > > > On Thu, Dec 21, 2023 at 10:07:13PM -0800, Luis Chamberlain wrote: > > > > > > > > If we want to go

Re: [PATCH 1/4] linux/export: Fix alignment for 64-bit ksymtab entries

2023-12-22 Thread Luis Chamberlain
On Fri, Dec 22, 2023 at 04:01:30PM +0900, Masahiro Yamada wrote: > On Fri, Dec 22, 2023 at 3:08 PM Luis Chamberlain wrote: > > > > On Thu, Dec 21, 2023 at 10:07:13PM -0800, Luis Chamberlain wrote: > > > > > > If we want to go bananas we could even get a graph of size of modules > > > > Sorry I

Re: [PATCH 1/4] linux/export: Fix alignment for 64-bit ksymtab entries

2023-12-21 Thread Masahiro Yamada
On Fri, Dec 22, 2023 at 3:08 PM Luis Chamberlain wrote: > > On Thu, Dec 21, 2023 at 10:07:13PM -0800, Luis Chamberlain wrote: > > > > If we want to go bananas we could even get a graph of size of modules > > Sorry I meant size of number of symbols Vs cost. > > Luis But, 1/4 is really a

Re: [PATCH 1/4] linux/export: Fix alignment for 64-bit ksymtab entries

2023-12-21 Thread Luis Chamberlain
On Thu, Dec 21, 2023 at 10:07:13PM -0800, Luis Chamberlain wrote: > > If we want to go bananas we could even get a graph of size of modules Sorry I meant size of number of symbols Vs cost. Luis

Re: [PATCH 1/4] linux/export: Fix alignment for 64-bit ksymtab entries

2023-12-21 Thread Luis Chamberlain
On Fri, Dec 22, 2023 at 01:01:23AM +0900, Masahiro Yamada wrote: > On Thu, Dec 21, 2023 at 7:22 PM Masahiro Yamada wrote: > > > > On Thu, Nov 23, 2023 at 7:18 AM wrote: > > > > > > From: Helge Deller > > > > > > An alignment of 4 bytes is wrong for 64-bit platforms which don't define > > >

Re: [PATCH 1/4] linux/export: Fix alignment for 64-bit ksymtab entries

2023-12-21 Thread Masahiro Yamada
On Thu, Dec 21, 2023 at 7:22 PM Masahiro Yamada wrote: > > On Thu, Nov 23, 2023 at 7:18 AM wrote: > > > > From: Helge Deller > > > > An alignment of 4 bytes is wrong for 64-bit platforms which don't define > > CONFIG_HAVE_ARCH_PREL32_RELOCATIONS (which then store 64-bit pointers). > > Fix their

Re: [PATCH 1/4] linux/export: Fix alignment for 64-bit ksymtab entries

2023-12-21 Thread Masahiro Yamada
On Thu, Nov 23, 2023 at 7:18 AM wrote: > > From: Helge Deller > > An alignment of 4 bytes is wrong for 64-bit platforms which don't define > CONFIG_HAVE_ARCH_PREL32_RELOCATIONS (which then store 64-bit pointers). > Fix their alignment to 8 bytes. > > Signed-off-by: Helge Deller This is

[PATCH 1/4] linux/export: Fix alignment for 64-bit ksymtab entries

2023-11-22 Thread deller
From: Helge Deller An alignment of 4 bytes is wrong for 64-bit platforms which don't define CONFIG_HAVE_ARCH_PREL32_RELOCATIONS (which then store 64-bit pointers). Fix their alignment to 8 bytes. Signed-off-by: Helge Deller --- include/linux/export-internal.h | 5 - 1 file changed, 4