Re: [PATCH 1/4] m68k/mac: More printk modernization

2017-10-27 Thread Finn Thain
On Sat, 28 Oct 2017, I wrote: > > Any particular reason why you didn't use pr_debug() here? I'm guessing > > it's because this is not a known pointer value? > > > > It's because the call to psc_debug_dump() is already conditional on > #ifdef DEBUG_PSC. > > Having the printk conditional on

Re: [PATCH 1/4] m68k/mac: More printk modernization

2017-10-27 Thread Finn Thain
On Sat, 28 Oct 2017, I wrote: > > Any particular reason why you didn't use pr_debug() here? I'm guessing > > it's because this is not a known pointer value? > > > > It's because the call to psc_debug_dump() is already conditional on > #ifdef DEBUG_PSC. > > Having the printk conditional on

Re: [PATCH 1/4] m68k/mac: More printk modernization

2017-10-27 Thread Finn Thain
On Fri, 27 Oct 2017, Kars de Jong wrote: > 2017-10-27 4:45 GMT+02:00 Finn Thain : > > Log message fragments used to be printed on one line but now get split > > up. Fix this. Also, suppress log spam that merely prints known pointer > > values. > > > > Tested-by: Stan

Re: [PATCH 1/4] m68k/mac: More printk modernization

2017-10-27 Thread Finn Thain
On Fri, 27 Oct 2017, Kars de Jong wrote: > 2017-10-27 4:45 GMT+02:00 Finn Thain : > > Log message fragments used to be printed on one line but now get split > > up. Fix this. Also, suppress log spam that merely prints known pointer > > values. > > > > Tested-by: Stan Johnson > > Signed-off-by:

Re: [PATCH 1/4] m68k/mac: More printk modernization

2017-10-27 Thread Kars de Jong
2017-10-27 4:45 GMT+02:00 Finn Thain : > Log message fragments used to be printed on one line but now get split up. > Fix this. Also, suppress log spam that merely prints known pointer values. > > Tested-by: Stan Johnson > Signed-off-by: Finn Thain

Re: [PATCH 1/4] m68k/mac: More printk modernization

2017-10-27 Thread Kars de Jong
2017-10-27 4:45 GMT+02:00 Finn Thain : > Log message fragments used to be printed on one line but now get split up. > Fix this. Also, suppress log spam that merely prints known pointer values. > > Tested-by: Stan Johnson > Signed-off-by: Finn Thain > --- > arch/m68k/mac/baboon.c | 2 +- >

[PATCH 1/4] m68k/mac: More printk modernization

2017-10-26 Thread Finn Thain
Log message fragments used to be printed on one line but now get split up. Fix this. Also, suppress log spam that merely prints known pointer values. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m68k/mac/baboon.c | 2 +-

[PATCH 1/4] m68k/mac: More printk modernization

2017-10-26 Thread Finn Thain
Log message fragments used to be printed on one line but now get split up. Fix this. Also, suppress log spam that merely prints known pointer values. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m68k/mac/baboon.c | 2 +- arch/m68k/mac/iop.c| 4 ++-- arch/m68k/mac/psc.c|