Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-18 Thread Guenter Roeck
On Thu, Apr 18, 2013 at 09:42:17AM -0700, Joe Perches wrote: > On Thu, 2013-04-18 at 06:35 -0700, Guenter Roeck wrote: > > On Wed, Apr 17, 2013 at 09:40:53PM -0700, Joe Perches wrote: > > > On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: > > > > On Sat, Apr 13, 2013 at 10:38:07PM +0200,

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-18 Thread Joe Perches
On Thu, 2013-04-18 at 06:35 -0700, Guenter Roeck wrote: > On Wed, Apr 17, 2013 at 09:40:53PM -0700, Joe Perches wrote: > > On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: > > > On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: > > > > > + return kempld_read8(pld, index) |

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-18 Thread Guenter Roeck
On Wed, Apr 17, 2013 at 09:40:53PM -0700, Joe Perches wrote: > On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: > > On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: > > > > + return kempld_read8(pld, index) | kempld_read8(pld, index+1) << 8; > > >

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-18 Thread Guenter Roeck
On Wed, Apr 17, 2013 at 09:40:53PM -0700, Joe Perches wrote: On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: + return kempld_read8(pld, index) | kempld_read8(pld, index+1) 8;

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-18 Thread Joe Perches
On Thu, 2013-04-18 at 06:35 -0700, Guenter Roeck wrote: On Wed, Apr 17, 2013 at 09:40:53PM -0700, Joe Perches wrote: On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: + return kempld_read8(pld, index) |

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-18 Thread Guenter Roeck
On Thu, Apr 18, 2013 at 09:42:17AM -0700, Joe Perches wrote: On Thu, 2013-04-18 at 06:35 -0700, Guenter Roeck wrote: On Wed, Apr 17, 2013 at 09:40:53PM -0700, Joe Perches wrote: On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-17 Thread Joe Perches
On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: > On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: > > > + return kempld_read8(pld, index) | kempld_read8(pld, index+1) << 8; > > index + 1) > > Please > Wondering

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-17 Thread Guenter Roeck
On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: [ ... ] > > > + return kempld_read8(pld, index) | kempld_read8(pld, index+1) << 8; > > index + 1) > Please > Wondering why does checkpatch not report those ? I

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-17 Thread Guenter Roeck
On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: [ ... ] + return kempld_read8(pld, index) | kempld_read8(pld, index+1) 8; index + 1) Please Wondering why does checkpatch not report those ? I just

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-17 Thread Joe Perches
On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: + return kempld_read8(pld, index) | kempld_read8(pld, index+1) 8; index + 1) Please Wondering why does

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-13 Thread Thomas Gleixner
On Mon, 8 Apr 2013, Kevin Strasser wrote: > --- /dev/null > +++ b/drivers/mfd/kempld-core.c > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include I seriously doubt, that all these includes are

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-13 Thread Thomas Gleixner
On Mon, 8 Apr 2013, Kevin Strasser wrote: --- /dev/null +++ b/drivers/mfd/kempld-core.c +#include linux/kernel.h +#include linux/module.h +#include linux/init.h +#include linux/list.h +#include linux/device.h +#include linux/platform_device.h +#include linux/dmi.h +#include linux/slab.h

[PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-08 Thread Kevin Strasser
From: Michael Brunner Add core MFD driver for the on-board PLD found on some Kontron embedded modules. The PLD device may provide functions like watchdog, GPIO, UART and I2C bus. The following modules are supported: * COMe-bIP# * COMe-bPC2 (ETXexpress-PC) * COMe-bSC#

[PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-08 Thread Kevin Strasser
From: Michael Brunner michael.brun...@kontron.com Add core MFD driver for the on-board PLD found on some Kontron embedded modules. The PLD device may provide functions like watchdog, GPIO, UART and I2C bus. The following modules are supported: * COMe-bIP# * COMe-bPC2