Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-04 Thread Mark Brown
On Tue, Mar 03, 2015 at 08:02:51AM -0800, Bjorn Andersson wrote: > rpm { > compatible = "qcom,rpm-apq8960"; > > regulators { > compatible = "qcom,rpm-pm8921-regulators"; Oh, so what you're saying is that the pm8921 is not actually a MFD at all? Why name it like a MFD

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-04 Thread Mark Brown
On Tue, Mar 03, 2015 at 08:02:51AM -0800, Bjorn Andersson wrote: rpm { compatible = qcom,rpm-apq8960; regulators { compatible = qcom,rpm-pm8921-regulators; Oh, so what you're saying is that the pm8921 is not actually a MFD at all? Why name it like a MFD component

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Stephen Boyd
On 03/03/15 14:17, Bjorn Andersson wrote: > On Tue 03 Mar 14:02 PST 2015, Stephen Boyd wrote: > >> On 03/03/15 13:54, Bjorn Andersson wrote: >>> On Tue 03 Mar 10:53 PST 2015, Stephen Boyd wrote: >>> On 03/02/15 20:25, Bjorn Andersson wrote: >>> [..] > + > +- vin_l1_l2_l12_l18-supply:

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Bjorn Andersson
On Tue 03 Mar 14:02 PST 2015, Stephen Boyd wrote: > On 03/03/15 13:54, Bjorn Andersson wrote: > > On Tue 03 Mar 10:53 PST 2015, Stephen Boyd wrote: > > > >> On 03/02/15 20:25, Bjorn Andersson wrote: > > [..] > >>> + > >>> +- vin_l1_l2_l12_l18-supply: > >>> +- vin_l24-supply: > >>> +-

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Stephen Boyd
On 03/03/15 13:54, Bjorn Andersson wrote: > On Tue 03 Mar 10:53 PST 2015, Stephen Boyd wrote: > >> On 03/02/15 20:25, Bjorn Andersson wrote: > [..] >>> + >>> +- vin_l1_l2_l12_l18-supply: >>> +- vin_l24-supply: >>> +- vin_l25-supply: >>> +- vin_l27-supply: >>> +- vin_l28-supply: >>> +-

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Bjorn Andersson
On Tue 03 Mar 10:53 PST 2015, Stephen Boyd wrote: > On 03/02/15 20:25, Bjorn Andersson wrote: [..] > > + > > +- vin_l1_l2_l12_l18-supply: > > +- vin_l24-supply: > > +- vin_l25-supply: > > +- vin_l27-supply: > > +- vin_l28-supply: > > +- vin_lvs_1_3_6-supply: > > +- vin_lvs2-supply: > > +-

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Stephen Boyd
On 03/02/15 20:25, Bjorn Andersson wrote: > > += SUBNODES > + > +The RPM exposes resources to its subnodes. The below bindings specify the set > +of valid subnodes that can operate on these resources. > + > +== Regulators > + > +Regulator notes are identified by their compatible: > + > +-

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Bjorn Andersson
On Tue 03 Mar 04:47 PST 2015, Mark Brown wrote: > On Mon, Mar 02, 2015 at 08:25:37PM -0800, Bjorn Andersson wrote: > > > +- compatible: > > + Usage: required > > + Value type: > > + Definition: must be one of: > > + "qcom,rpm-pm8058-regulators" > > +

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Mark Brown
On Mon, Mar 02, 2015 at 08:25:37PM -0800, Bjorn Andersson wrote: > +- compatible: > + Usage: required > + Value type: > + Definition: must be one of: > + "qcom,rpm-pm8058-regulators" > + "qcom,rpm-pm8901-regulators" > +

[PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Bjorn Andersson
Add the regulator subnodes to the Qualcomm RPM MFD device tree bindings. Signed-off-by: Bjorn Andersson --- As the previously accepted binding didn't cover any functionality but registering the mfd core there is no users, hence it's fine to drop the two required fields at this time.

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Mark Brown
On Mon, Mar 02, 2015 at 08:25:37PM -0800, Bjorn Andersson wrote: +- compatible: + Usage: required + Value type: string + Definition: must be one of: + qcom,rpm-pm8058-regulators + qcom,rpm-pm8901-regulators +

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Bjorn Andersson
On Tue 03 Mar 04:47 PST 2015, Mark Brown wrote: On Mon, Mar 02, 2015 at 08:25:37PM -0800, Bjorn Andersson wrote: +- compatible: + Usage: required + Value type: string + Definition: must be one of: + qcom,rpm-pm8058-regulators +

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Stephen Boyd
On 03/02/15 20:25, Bjorn Andersson wrote: += SUBNODES + +The RPM exposes resources to its subnodes. The below bindings specify the set +of valid subnodes that can operate on these resources. + +== Regulators + +Regulator notes are identified by their compatible: + +- compatible: +

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Bjorn Andersson
On Tue 03 Mar 10:53 PST 2015, Stephen Boyd wrote: On 03/02/15 20:25, Bjorn Andersson wrote: [..] + +- vin_l1_l2_l12_l18-supply: +- vin_l24-supply: +- vin_l25-supply: +- vin_l27-supply: +- vin_l28-supply: +- vin_lvs_1_3_6-supply: +- vin_lvs2-supply: +- vin_lvs_4_5_7-supply: +-

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Stephen Boyd
On 03/03/15 13:54, Bjorn Andersson wrote: On Tue 03 Mar 10:53 PST 2015, Stephen Boyd wrote: On 03/02/15 20:25, Bjorn Andersson wrote: [..] + +- vin_l1_l2_l12_l18-supply: +- vin_l24-supply: +- vin_l25-supply: +- vin_l27-supply: +- vin_l28-supply: +- vin_lvs_1_3_6-supply: +-

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Bjorn Andersson
On Tue 03 Mar 14:02 PST 2015, Stephen Boyd wrote: On 03/03/15 13:54, Bjorn Andersson wrote: On Tue 03 Mar 10:53 PST 2015, Stephen Boyd wrote: On 03/02/15 20:25, Bjorn Andersson wrote: [..] + +- vin_l1_l2_l12_l18-supply: +- vin_l24-supply: +- vin_l25-supply: +- vin_l27-supply:

Re: [PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Stephen Boyd
On 03/03/15 14:17, Bjorn Andersson wrote: On Tue 03 Mar 14:02 PST 2015, Stephen Boyd wrote: On 03/03/15 13:54, Bjorn Andersson wrote: On Tue 03 Mar 10:53 PST 2015, Stephen Boyd wrote: On 03/02/15 20:25, Bjorn Andersson wrote: [..] + +- vin_l1_l2_l12_l18-supply: +- vin_l24-supply: +-

[PATCH 1/4] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes

2015-03-03 Thread Bjorn Andersson
Add the regulator subnodes to the Qualcomm RPM MFD device tree bindings. Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- As the previously accepted binding didn't cover any functionality but registering the mfd core there is no users, hence it's fine to drop the two required