Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-05 Thread Johannes Weiner
On Mon, Aug 05, 2013 at 05:50:41PM +0900, Joonsoo Kim wrote: > On Mon, Aug 05, 2013 at 05:10:08PM +0900, Joonsoo Kim wrote: > > Hello, Michal. > > > > On Fri, Aug 02, 2013 at 11:36:07PM +0200, Michal Hocko wrote: > > > On Fri 02-08-13 16:47:10, Johannes Weiner wrote: > > > > On Fri, Aug 02, 2013

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-05 Thread Michal Hocko
On Mon 05-08-13 17:50:41, Joonsoo Kim wrote: [...] > IMHO, although there is no effect, it is better to add likely macro, > because arrangement can be changed from time to time without any > consideration of assembly code generation. How about your opinion, > Johannes and Michal? This is a matter

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-05 Thread Joonsoo Kim
On Mon, Aug 05, 2013 at 05:10:08PM +0900, Joonsoo Kim wrote: > Hello, Michal. > > On Fri, Aug 02, 2013 at 11:36:07PM +0200, Michal Hocko wrote: > > On Fri 02-08-13 16:47:10, Johannes Weiner wrote: > > > On Fri, Aug 02, 2013 at 06:27:22PM +0200, Michal Hocko wrote: > > > > On Fri 02-08-13

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-05 Thread Joonsoo Kim
Hello, Michal. On Fri, Aug 02, 2013 at 11:36:07PM +0200, Michal Hocko wrote: > On Fri 02-08-13 16:47:10, Johannes Weiner wrote: > > On Fri, Aug 02, 2013 at 06:27:22PM +0200, Michal Hocko wrote: > > > On Fri 02-08-13 11:07:56, Joonsoo Kim wrote: > > > > We rarely allocate a page with

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-05 Thread Joonsoo Kim
Hello, Michal. On Fri, Aug 02, 2013 at 11:36:07PM +0200, Michal Hocko wrote: On Fri 02-08-13 16:47:10, Johannes Weiner wrote: On Fri, Aug 02, 2013 at 06:27:22PM +0200, Michal Hocko wrote: On Fri 02-08-13 11:07:56, Joonsoo Kim wrote: We rarely allocate a page with ALLOC_NO_WATERMARKS and

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-05 Thread Joonsoo Kim
On Mon, Aug 05, 2013 at 05:10:08PM +0900, Joonsoo Kim wrote: Hello, Michal. On Fri, Aug 02, 2013 at 11:36:07PM +0200, Michal Hocko wrote: On Fri 02-08-13 16:47:10, Johannes Weiner wrote: On Fri, Aug 02, 2013 at 06:27:22PM +0200, Michal Hocko wrote: On Fri 02-08-13 11:07:56, Joonsoo

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-05 Thread Michal Hocko
On Mon 05-08-13 17:50:41, Joonsoo Kim wrote: [...] IMHO, although there is no effect, it is better to add likely macro, because arrangement can be changed from time to time without any consideration of assembly code generation. How about your opinion, Johannes and Michal? This is a matter of

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-05 Thread Johannes Weiner
On Mon, Aug 05, 2013 at 05:50:41PM +0900, Joonsoo Kim wrote: On Mon, Aug 05, 2013 at 05:10:08PM +0900, Joonsoo Kim wrote: Hello, Michal. On Fri, Aug 02, 2013 at 11:36:07PM +0200, Michal Hocko wrote: On Fri 02-08-13 16:47:10, Johannes Weiner wrote: On Fri, Aug 02, 2013 at 06:27:22PM

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-02 Thread Michal Hocko
On Fri 02-08-13 16:47:10, Johannes Weiner wrote: > On Fri, Aug 02, 2013 at 06:27:22PM +0200, Michal Hocko wrote: > > On Fri 02-08-13 11:07:56, Joonsoo Kim wrote: > > > We rarely allocate a page with ALLOC_NO_WATERMARKS and it is used > > > in slow path. For making fast path more faster, add likely

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-02 Thread Johannes Weiner
On Fri, Aug 02, 2013 at 06:27:22PM +0200, Michal Hocko wrote: > On Fri 02-08-13 11:07:56, Joonsoo Kim wrote: > > We rarely allocate a page with ALLOC_NO_WATERMARKS and it is used > > in slow path. For making fast path more faster, add likely macro to > > help compiler optimization. > > The code

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-02 Thread Johannes Weiner
On Fri, Aug 02, 2013 at 11:07:56AM +0900, Joonsoo Kim wrote: > We rarely allocate a page with ALLOC_NO_WATERMARKS and it is used > in slow path. For making fast path more faster, add likely macro to > help compiler optimization. > > Signed-off-by: Joonsoo Kim Acked-by: Johannes Weiner -- To

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-02 Thread Michal Hocko
On Fri 02-08-13 11:07:56, Joonsoo Kim wrote: > We rarely allocate a page with ALLOC_NO_WATERMARKS and it is used > in slow path. For making fast path more faster, add likely macro to > help compiler optimization. The code is different in mmotm tree (see mm: page_alloc: rearrange watermark

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-02 Thread Michal Hocko
On Fri 02-08-13 11:07:56, Joonsoo Kim wrote: We rarely allocate a page with ALLOC_NO_WATERMARKS and it is used in slow path. For making fast path more faster, add likely macro to help compiler optimization. The code is different in mmotm tree (see mm: page_alloc: rearrange watermark checking

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-02 Thread Johannes Weiner
On Fri, Aug 02, 2013 at 11:07:56AM +0900, Joonsoo Kim wrote: We rarely allocate a page with ALLOC_NO_WATERMARKS and it is used in slow path. For making fast path more faster, add likely macro to help compiler optimization. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Acked-by: Johannes

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-02 Thread Johannes Weiner
On Fri, Aug 02, 2013 at 06:27:22PM +0200, Michal Hocko wrote: On Fri 02-08-13 11:07:56, Joonsoo Kim wrote: We rarely allocate a page with ALLOC_NO_WATERMARKS and it is used in slow path. For making fast path more faster, add likely macro to help compiler optimization. The code is

Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-02 Thread Michal Hocko
On Fri 02-08-13 16:47:10, Johannes Weiner wrote: On Fri, Aug 02, 2013 at 06:27:22PM +0200, Michal Hocko wrote: On Fri 02-08-13 11:07:56, Joonsoo Kim wrote: We rarely allocate a page with ALLOC_NO_WATERMARKS and it is used in slow path. For making fast path more faster, add likely macro to

[PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-01 Thread Joonsoo Kim
We rarely allocate a page with ALLOC_NO_WATERMARKS and it is used in slow path. For making fast path more faster, add likely macro to help compiler optimization. Signed-off-by: Joonsoo Kim diff --git a/mm/page_alloc.c b/mm/page_alloc.c index b100255..86ad44b 100644 --- a/mm/page_alloc.c +++

[PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization

2013-08-01 Thread Joonsoo Kim
We rarely allocate a page with ALLOC_NO_WATERMARKS and it is used in slow path. For making fast path more faster, add likely macro to help compiler optimization. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com diff --git a/mm/page_alloc.c b/mm/page_alloc.c index b100255..86ad44b 100644 ---