Re: [PATCH 1/4] regulator: ab8500: Get rid of is_enabled from struct ab8500_regulator_info

2013-04-08 Thread Mark Brown
On Sun, Apr 07, 2013 at 11:12:28PM +0800, Axel Lin wrote: > The intention of this patch is to simplify the code. Applied all, thanks. signature.asc Description: Digital signature

Re: [PATCH 1/4] regulator: ab8500: Get rid of is_enabled from struct ab8500_regulator_info

2013-04-08 Thread Lee Jones
On Sun, 07 Apr 2013, Axel Lin wrote: > The intention of this patch is to simplify the code. > > Maintain the is_enabled flag is not trivial, it not only needs to set/clear > the > flag in disable()/enable() but also needs to set the flag in is_enable() to > get > initial status. The only

Re: [PATCH 1/4] regulator: ab8500: Get rid of is_enabled from struct ab8500_regulator_info

2013-04-08 Thread Lee Jones
On Sun, 07 Apr 2013, Axel Lin wrote: The intention of this patch is to simplify the code. Maintain the is_enabled flag is not trivial, it not only needs to set/clear the flag in disable()/enable() but also needs to set the flag in is_enable() to get initial status. The only benefit of

Re: [PATCH 1/4] regulator: ab8500: Get rid of is_enabled from struct ab8500_regulator_info

2013-04-08 Thread Mark Brown
On Sun, Apr 07, 2013 at 11:12:28PM +0800, Axel Lin wrote: The intention of this patch is to simplify the code. Applied all, thanks. signature.asc Description: Digital signature

[PATCH 1/4] regulator: ab8500: Get rid of is_enabled from struct ab8500_regulator_info

2013-04-07 Thread Axel Lin
The intention of this patch is to simplify the code. Maintain the is_enabled flag is not trivial, it not only needs to set/clear the flag in disable()/enable() but also needs to set the flag in is_enable() to get initial status. The only benefit of keeping is_enabled flag is just save a register

[PATCH 1/4] regulator: ab8500: Get rid of is_enabled from struct ab8500_regulator_info

2013-04-07 Thread Axel Lin
The intention of this patch is to simplify the code. Maintain the is_enabled flag is not trivial, it not only needs to set/clear the flag in disable()/enable() but also needs to set the flag in is_enable() to get initial status. The only benefit of keeping is_enabled flag is just save a register