Re: [PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer

2016-11-21 Thread Baolin Wang
On 21 November 2016 at 16:56, Thomas Gleixner wrote: > On Mon, 21 Nov 2016, Baolin Wang wrote: >> On 21 November 2016 at 16:13, Ingo Molnar wrote: >> > Hm, there's a weirdness here: if freezer_delta != 0 when >> > alarmtimer_suspend() is >> > called then

Re: [PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer

2016-11-21 Thread Baolin Wang
On 21 November 2016 at 16:56, Thomas Gleixner wrote: > On Mon, 21 Nov 2016, Baolin Wang wrote: >> On 21 November 2016 at 16:13, Ingo Molnar wrote: >> > Hm, there's a weirdness here: if freezer_delta != 0 when >> > alarmtimer_suspend() is >> > called then type might be '0', although it's not

Re: [PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer

2016-11-21 Thread Thomas Gleixner
On Mon, 21 Nov 2016, Baolin Wang wrote: > On 21 November 2016 at 16:13, Ingo Molnar wrote: > > Hm, there's a weirdness here: if freezer_delta != 0 when > > alarmtimer_suspend() is > > called then type might be '0', although it's not alarm_bases[0] this value > > is > > picked

Re: [PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer

2016-11-21 Thread Thomas Gleixner
On Mon, 21 Nov 2016, Baolin Wang wrote: > On 21 November 2016 at 16:13, Ingo Molnar wrote: > > Hm, there's a weirdness here: if freezer_delta != 0 when > > alarmtimer_suspend() is > > called then type might be '0', although it's not alarm_bases[0] this value > > is > > picked up from. > > > >

Re: [PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer

2016-11-21 Thread Baolin Wang
Hi Ingo, On 21 November 2016 at 16:13, Ingo Molnar wrote: > > * John Stultz wrote: > >> @@ -222,7 +226,7 @@ static int alarmtimer_suspend(struct device *dev) >> ktime_t min, now; >> unsigned long flags; >> struct rtc_device *rtc; >> -

Re: [PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer

2016-11-21 Thread Baolin Wang
Hi Ingo, On 21 November 2016 at 16:13, Ingo Molnar wrote: > > * John Stultz wrote: > >> @@ -222,7 +226,7 @@ static int alarmtimer_suspend(struct device *dev) >> ktime_t min, now; >> unsigned long flags; >> struct rtc_device *rtc; >> - int i; >> + int i, type = 0; >>

Re: [PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer

2016-11-21 Thread Ingo Molnar
* John Stultz wrote: > @@ -222,7 +226,7 @@ static int alarmtimer_suspend(struct device *dev) > ktime_t min, now; > unsigned long flags; > struct rtc_device *rtc; > - int i; > + int i, type = 0; > int ret; > >

Re: [PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer

2016-11-21 Thread Ingo Molnar
* John Stultz wrote: > @@ -222,7 +226,7 @@ static int alarmtimer_suspend(struct device *dev) > ktime_t min, now; > unsigned long flags; > struct rtc_device *rtc; > - int i; > + int i, type = 0; > int ret; > > spin_lock_irqsave(_delta_lock, flags); > @@

[PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer

2016-11-18 Thread John Stultz
From: Baolin Wang For system debugging, we sometimes want to know who sets one alarm timer, the time of the timer, when the timer started and fired and so on. Thus adding tracepoints can help us trace the alarmtimer information. For example, when we debug the system

[PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer

2016-11-18 Thread John Stultz
From: Baolin Wang For system debugging, we sometimes want to know who sets one alarm timer, the time of the timer, when the timer started and fired and so on. Thus adding tracepoints can help us trace the alarmtimer information. For example, when we debug the system supend/resume, if the system