Re: [PATCH 1/4 v2] firmware: stratix10-svc: Fix genpool creation error handling

2020-04-29 Thread Markus Elfring
> 'svc_create_memory_pool()' returns an error pointer on error, not NULL. Such information is helpful. > Fix the corresponding test and return value accordingly. > > Move the genpool allocation after a few devm_kzalloc in order to ease > error handling. How do you think about a wording variant

[PATCH 1/4 v2] firmware: stratix10-svc: Fix genpool creation error handling

2020-04-29 Thread Christophe JAILLET
'svc_create_memory_pool()' returns an error pointer on error, not NULL. Fix the corresponding test and return value accordingly. Move the genpool allocation after a few devm_kzalloc in order to ease error handling. Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")