On Wed, 3 Feb 2016, Paul Burton wrote:
> > Hmm, this looks like a fatal error condition to me, the module won't
> > load. Why `pr_warn' rather than `pr_err' then? Likewise in the other
> > file.
>
> To me fatality implies death, and nothing dies here. The module isn't
> loaded but that's
On Wed, Feb 03, 2016 at 12:24:38PM +, Maciej W. Rozycki wrote:
> On Wed, 3 Feb 2016, Paul Burton wrote:
>
> > --- a/arch/mips/kernel/module-rela.c
> > +++ b/arch/mips/kernel/module-rela.c
> > @@ -134,9 +135,21 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char
> > *strtab,
> >
On Wed, 3 Feb 2016, Paul Burton wrote:
> --- a/arch/mips/kernel/module-rela.c
> +++ b/arch/mips/kernel/module-rela.c
> @@ -134,9 +135,21 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char
> *strtab,
> return -ENOENT;
> }
>
> - v =
On Wed, Feb 03, 2016 at 03:44:41AM +, Paul Burton wrote:
> When an unsupported reloc is encountered in a module, we currently
> blindly branch to whatever would be at its entry in the reloc handler
> function pointer arrays. This may be NULL, or if the unsupported reloc
> has a type greater
On Wed, Feb 03, 2016 at 03:44:41AM +, Paul Burton wrote:
> When an unsupported reloc is encountered in a module, we currently
> blindly branch to whatever would be at its entry in the reloc handler
> function pointer arrays. This may be NULL, or if the unsupported reloc
> has a type greater
On Wed, 3 Feb 2016, Paul Burton wrote:
> --- a/arch/mips/kernel/module-rela.c
> +++ b/arch/mips/kernel/module-rela.c
> @@ -134,9 +135,21 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char
> *strtab,
> return -ENOENT;
> }
>
> - v =
On Wed, Feb 03, 2016 at 12:24:38PM +, Maciej W. Rozycki wrote:
> On Wed, 3 Feb 2016, Paul Burton wrote:
>
> > --- a/arch/mips/kernel/module-rela.c
> > +++ b/arch/mips/kernel/module-rela.c
> > @@ -134,9 +135,21 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char
> > *strtab,
> >
On Wed, 3 Feb 2016, Paul Burton wrote:
> > Hmm, this looks like a fatal error condition to me, the module won't
> > load. Why `pr_warn' rather than `pr_err' then? Likewise in the other
> > file.
>
> To me fatality implies death, and nothing dies here. The module isn't
> loaded but that's
When an unsupported reloc is encountered in a module, we currently
blindly branch to whatever would be at its entry in the reloc handler
function pointer arrays. This may be NULL, or if the unsupported reloc
has a type greater than that of the supported reloc with the highest
type then we'll
When an unsupported reloc is encountered in a module, we currently
blindly branch to whatever would be at its entry in the reloc handler
function pointer arrays. This may be NULL, or if the unsupported reloc
has a type greater than that of the supported reloc with the highest
type then we'll
10 matches
Mail list logo
