Re: [PATCH 1/5] SCHED: add some "wait..on_bit...timeout()" interfaces.

2014-09-24 Thread Trond Myklebust
On Wed, Sep 24, 2014 at 11:23 PM, NeilBrown wrote: > On Wed, 24 Sep 2014 09:04:18 +0200 Ingo Molnar wrote: > >> >> * NeilBrown wrote: >> >> > @@ -859,6 +860,8 @@ int wake_bit_function(wait_queue_t *wait, unsigned >> > mode, int sync, void *key); >> > >> > extern int bit_wait(struct

Re: [PATCH 1/5] SCHED: add some "wait..on_bit...timeout()" interfaces.

2014-09-24 Thread NeilBrown
On Wed, 24 Sep 2014 09:04:18 +0200 Ingo Molnar wrote: > > * NeilBrown wrote: > > > @@ -859,6 +860,8 @@ int wake_bit_function(wait_queue_t *wait, unsigned > > mode, int sync, void *key); > > > > extern int bit_wait(struct wait_bit_key *); > > extern int bit_wait_io(struct wait_bit_key *);

Re: [PATCH 1/5] SCHED: add some "wait..on_bit...timeout()" interfaces.

2014-09-24 Thread Ingo Molnar
* NeilBrown wrote: > @@ -859,6 +860,8 @@ int wake_bit_function(wait_queue_t *wait, unsigned mode, > int sync, void *key); > > extern int bit_wait(struct wait_bit_key *); > extern int bit_wait_io(struct wait_bit_key *); > +extern int bit_wait_timeout(struct wait_bit_key *); > +extern int

Re: [PATCH 1/5] SCHED: add some wait..on_bit...timeout() interfaces.

2014-09-24 Thread Ingo Molnar
* NeilBrown ne...@suse.de wrote: @@ -859,6 +860,8 @@ int wake_bit_function(wait_queue_t *wait, unsigned mode, int sync, void *key); extern int bit_wait(struct wait_bit_key *); extern int bit_wait_io(struct wait_bit_key *); +extern int bit_wait_timeout(struct wait_bit_key *); +extern

Re: [PATCH 1/5] SCHED: add some wait..on_bit...timeout() interfaces.

2014-09-24 Thread NeilBrown
On Wed, 24 Sep 2014 09:04:18 +0200 Ingo Molnar mi...@kernel.org wrote: * NeilBrown ne...@suse.de wrote: @@ -859,6 +860,8 @@ int wake_bit_function(wait_queue_t *wait, unsigned mode, int sync, void *key); extern int bit_wait(struct wait_bit_key *); extern int bit_wait_io(struct

Re: [PATCH 1/5] SCHED: add some wait..on_bit...timeout() interfaces.

2014-09-24 Thread Trond Myklebust
On Wed, Sep 24, 2014 at 11:23 PM, NeilBrown ne...@suse.de wrote: On Wed, 24 Sep 2014 09:04:18 +0200 Ingo Molnar mi...@kernel.org wrote: * NeilBrown ne...@suse.de wrote: @@ -859,6 +860,8 @@ int wake_bit_function(wait_queue_t *wait, unsigned mode, int sync, void *key); extern int

[PATCH 1/5] SCHED: add some "wait..on_bit...timeout()" interfaces.

2014-09-23 Thread NeilBrown
In commit c1221321b7c25b53204447cff9949a6d5a7c sched: Allow wait_on_bit_action() functions to support a timeout I suggested that a "wait_on_bit_timeout()" interface would not meet my need. This isn't true - I was just over-engineering. Including a 'private' field in wait_bit_key instead

[PATCH 1/5] SCHED: add some wait..on_bit...timeout() interfaces.

2014-09-23 Thread NeilBrown
In commit c1221321b7c25b53204447cff9949a6d5a7c sched: Allow wait_on_bit_action() functions to support a timeout I suggested that a wait_on_bit_timeout() interface would not meet my need. This isn't true - I was just over-engineering. Including a 'private' field in wait_bit_key instead of